Refactor backup service parameters and add default SSH host value

scripts/scheduler/entrypoint.sh

@@ -3,7 +3,7 @@
 cd /scripts
 DEBUG_MODE=${DEBUG_MODE:-false}
 
-VERSION="1.1.3"
+VERSION="1.1.4"
 
 #DOCKER_REGISTRY_URL=${DOCKER_REGISTRY_URL:-registry.format.hu}
 DOCKER_REGISTRY_URL=${DOCKER_REGISTRY_URL:-safebox}
@@ -142,20 +142,38 @@ generate_backup_server_secrets () {
 
         echo '{ 
             "backupserver":{
+                "SSH_HOST":"'$SSH_HOST'",
                 "SSH_USER":"'$SSH_USER'",
                 "SSH_PORT":"'$SSH_PORT'",
                 "SSH_PASSWORD":"'$SSH_PASSWORD'",
-                "PASSWORD":"'$PASSWORD'",
+                "BACKUP_PASSWORD":"'$BACKUP_PASSWORD'",
                 "PERIOD":"'$PERIOD'",
                 "COMPRESSION":"'$COMPRESSION'",
                 "DIRECTORIES":"'$DIRECTORIES'",
-                "SERVICES":"'$SERVICES'",
+                "SERVICES":"'$SERVICES'"
-                "BACKUP_LOCAL_CLIENTS":"'$BACKUP_LOCAL_CLIENTS'",
-                "BACKUP_VPN_CLIENTS":"'$BACKUP_VPN_CLIENTS'"
             }
         }' | jq -r . > $SECRET_DIR/backup/server/backup.json
 }
 
+defaulting_missing_paramaters() {
+
+    if [ "$SSH_HOST" == "" ] || [ "$SSH_HOST" == "null" ]; then
+        SSH_HOST="localhost"
+    fi
+
+    if [ "$SSH_PORT" == "" ] || [ "$SSH_PORT" == "null" ]; then
+        SSH_PORT="20022"
+    fi
+
+    if [ "$SSH_USER" == "" ] || [ "$SSH_USER" == "null" ]; then
+        SSH_USER="backup"
+    fi
+
+    if [ "$SSH_PASSWORD" == "" ] || [ "$SSH_PASSWORD" == "null" ]; then
+        SSH_PASSWORD="backup"
+    fi
+}
+
 create_backup_service () {
 
     ADDITIONAL=""
@@ -224,22 +242,22 @@ create_backup_service () {
 
 backup_set_service() {
 
-
+    local BACKUP_PASSWORD="$1"
-    local PASSWORD="$1"
     local PERIOD="$2"
     local COMPRESSION="$3"
 
     local PLANNED_TIME="$(echo "$4" | base64 -d)"
     local DIRECTRIES="$5"
     local SERVICES="$6"
-    local BACKUP_LOCAL_CLIENTS="$7"
+    local SSH_HOST="$7"
-    local BACKUP_VPN_CLIENTS="$8"
 
-    local VPN="$9"
+    local VPN="$8"
-    local SSH_PORT="${10:-20022}"
+    local SSH_PORT="$9"
-    local SSH_USER="${11:-"backup"}"
+    local SSH_USER="${10}"
-    local SSH_PASSWORD="${12:-"backup"}"
+    local SSH_PASSWORD="${11}"
-    local OPERATION="${13}"
+    local OPERATION="${12}"
+
+    defaulting_missing_paramaters
 
     if [ "$OPERATION" == "DELETE" ]; then
 
@@ -293,12 +311,14 @@ backup_set_client() {
     local NAME="$1"
     local SIZE="$2"
     local VPN="$3"
-    local SSH_PORT="${4:-20022}"
+    local SSH_PORT="$4"
-    local SSH_USER="${5:-"backup"}"
+    local SSH_USER="$5"
-    local SSH_PASSWORD="${6:-"backup"}"
+    local SSH_PASSWORD="$6"
     local OPERATION="$7"
     local VPN_KEY="$8"
 
+    defaulting_missing_paramaters
+
     if [ "$OPERATION" == "DELETE" ]; then
         # delete service
         if [ -f "/etc/user/config/services/service-backup-client-$NAME.json" ]; then
@@ -326,7 +346,7 @@ backup_set_client() {
 
         ADDITIONAL=""
         ADDITIONAL='"EXTRA":"--restart=always","PRE_START":[],"DEPEND":[],"CMD": ""'
-        ENVS='"ENVS": [{"SSH_USER":"'$SSH_USER'"},{"SSH_PORT":"'$SSH_PORT'"},{"SSH_PASSWORD":"'$SSH_PASSWORD'"},{"VPN_CLIENT_KEY":"'$VPN_KEY'"}],'
+        ENVS='"ENVS":[{"SSH_USER":"'$SSH_USER'"},{"SSH_PORT":"'$SSH_PORT'"},{"SSH_PASSWORD":"'$SSH_PASSWORD'"},{"VPN_CLIENT_KEY":"'$VPN_KEY'"}],'
 
         echo '{
     "main": {
@@ -369,6 +389,7 @@ backup_set_client() {
         {
         "SOURCE": "/etc/user/data/backup/clients/'$NAME'/ssh",                   
         "DEST": "/home/'$SSH_USER'/.ssh",
+        "TYPE": "rw"
         }
             ],
     "POST_START": []
@@ -1320,7 +1341,7 @@ execute_task() {
 
         elif [ "$TASK_TYPE" == "backup_set_service" ]; then
 
-            PASSWORD="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_SERVER_PASSWORD')"
+            BACKUP_PASSWORD="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_SERVER_PASSWORD')"
             PERIOD="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_PERIOD')"
             COMPRESSION="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_COMPRESSION')"
             PLANNED_TIME="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_PLANNED_TIME')"
@@ -1329,13 +1350,14 @@ execute_task() {
             BACKUP_LOCAL_CLIENTS="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_LOCAL_CLIENTS')"
             BACKUP_VPN_CLIENTS="$(echo $B64_JSON | base64 -d | jq -r '.BACKUP_VPN_CLIENTS')"
             VPN="$(echo $B64_JSON | base64 -d | jq -r '.VPN')"
+            SSH_HOST="$(echo $B64_JSON | base64 -d | jq -r '.SSH_HOST')"
             SSH_PORT="$(echo $B64_JSON | base64 -d | jq -r '.SSH_PORT')"
             SSH_USER="$(echo $B64_JSON | base64 -d | jq -r '.SSH_USER')"
             SSH_PASSWORD="$(echo $B64_JSON | base64 -d | jq -r '.SSH_PASSWORD')"
             OPERATION="$(echo $B64_JSON | base64 -d | jq -r '.OPERATION')"
 
             echo "task type is backup_set_service"
-            backup_set_service "$PASSWORD" "$PERIOD" "$COMPRESSION" "$PLANNED_TIME" "$DIRECTRIES" "$SERVICES" "$BACKUP_LOCAL_CLIENTS" "$BACKUP_VPN_CLIENTS" "$VPN" "$SSH_PORT" "$SSH_USER" "$SSH_PASSWORD" "$OPERATION"
+            backup_set_service "$BACKUP_PASSWORD" "$PERIOD" "$COMPRESSION" "$PLANNED_TIME" "$DIRECTRIES" "$SERVICES" "$SSH_HOST" "$VPN" "$SSH_PORT" "$SSH_USER" "$SSH_PASSWORD" "$OPERATION"
 
         elif [ "$TASK_TYPE" == "backup_set_client" ]; then
             
@@ -1392,9 +1414,9 @@ execute_task() {
         sh /scripts/check_pid.sh "$PID" "$SHARED" "$TASK_NAME-$NAME" "$DATE" "$DEBUG" &
     fi
 
-    if [ "$TASK_NAME" != "check_vpn" ]; then
+#    if [ "$TASK_NAME" != "check_vpn" ]; then
-        debug "JSON_TARGET: $JSON_TARGET"
+#        debug "JSON_TARGET: $JSON_TARGET"
-    fi
+#    fi
 
     if [ "$JSON_TARGET" != "" ]; then
         add_json_target