safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-641: Follow widely-accepted public static final Logger idiom.

Browse Source 
From https://github.com/apache/guacamole-client/pull/336#discussion_r241549475:

>
> SLF4J formerly recommended that instance variables be used
> (non-static), but no longer takes either stance:
> https://www.slf4j.org/faq.html#declared_static
>
> If we have to pick something to be the standard going forward, I'd
> say let's stick with the accepted idiom of `private static final`
> loggers, with the exception being where it's actually necessary to
> not be `static` (dependency injection).
>
This commit is contained in:
Michael Jumper
2022-01-21 15:23:40 -08:00
parent e0fce54056
commit 0359aa6225
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-base/src/main/java/org/apache/guacamole/auth/vault/secret/CachedVaultSecretService.java
View File

@@ -40,7 +40,7 @@ public abstract class CachedVaultSecretService implements VaultSecretService {
/**
* Logger for this class.
*/
private final Logger logger = LoggerFactory.getLogger(CachedVaultSecretService.class);
private static final Logger logger = LoggerFactory.getLogger(CachedVaultSecretService.class);
/**
* The cached value of a secret.

2
extensions/guacamole-auth-vault/modules/guacamole-auth-vault-base/src/main/java/org/apache/guacamole/auth/vault/user/VaultUserContext.java
View File

@@ -49,7 +49,7 @@ public class VaultUserContext extends TokenInjectingUserContext {
/**
* Logger for this class.
*/
private final Logger logger = LoggerFactory.getLogger(VaultUserContext.class);
private static final Logger logger = LoggerFactory.getLogger(VaultUserContext.class);
/**
* The name of the token which will be replaced with the username of the