safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-197: Handle IllegalArgumentException when parsing state string.

Browse Source
This commit is contained in:
Nick Couchman
2018-02-03 23:23:27 -05:00
parent 41dd9fc60d
commit 0729fa09cd
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
View File

@@ -21,6 +21,7 @@ package org.apache.guacamole.auth.radius;
import com.google.inject.Inject; import com.google.inject.Inject;
import com.google.inject.Provider; import com.google.inject.Provider;
import java.lang.IllegalArgumentException;
import java.nio.charset.Charset; import java.nio.charset.Charset;
import java.util.Arrays; import java.util.Arrays;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
@@ -161,7 +162,7 @@ public class AuthenticationProviderService {
if (stateString == null) { if (stateString == null) {
logger.error("Could not retrieve RADIUS state."); logger.error("Could not retrieve RADIUS state.");
logger.debug("Received null value while retrieving RADIUS state parameter."); logger.debug("Received null value while retrieving RADIUS state parameter.");
throws new GuacamoleInvalidCredentialsException("Authentication error.", CredentialsInfo.USERNAME_PASSWORD); throw new GuacamoleInvalidCredentialsException("Authentication error.", CredentialsInfo.USERNAME_PASSWORD);
} }
byte[] stateBytes = DatatypeConverter.parseHexBinary(stateString); byte[] stateBytes = DatatypeConverter.parseHexBinary(stateString);
@@ -169,6 +170,11 @@ public class AuthenticationProviderService {
challengeResponse, challengeResponse,
stateBytes); stateBytes);
} }
catch (IllegalArgumentException e) {
logger.error("Illegal argument while parsing RADIUS state string.", e.getMessage());
logger.debug("Illegal argument found while parsing the RADIUS state string.", e);
throw new GuacamoleInvalidCredentialsException("Authentication error.", CredentialsInfo.USERNAME_PASSWORD);
}
catch (GuacamoleException e) { catch (GuacamoleException e) {
logger.error("Cannot configure RADIUS server: {}", e.getMessage()); logger.error("Cannot configure RADIUS server: {}", e.getMessage());
logger.debug("Error configuring RADIUS server.", e); logger.debug("Error configuring RADIUS server.", e);