safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-07 05:31:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUAC-1188 Use canReadPermissions() - do not reimplement permission checks.

Browse Source
This commit is contained in:
James Muehlner
2015-05-13 21:50:20 -07:00
parent f354e4b463
commit 13fa327ba4
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/glyptodon/guacamole/auth/jdbc/permission/SystemPermissionService.java
View File

@@ -151,9 +151,8 @@ public class SystemPermissionService
public SystemPermission retrievePermission(AuthenticatedUser user, public SystemPermission retrievePermission(AuthenticatedUser user,
ModeledUser targetUser, SystemPermission.Type type) throws GuacamoleException { ModeledUser targetUser, SystemPermission.Type type) throws GuacamoleException {
// Only an admin can read permissions that aren't his own // Retrieve permissions only if allowed
if (user.getUser().getIdentifier().equals(targetUser.getIdentifier()) if (canReadPermissions(user, targetUser)) {
|| user.getUser().isAdministrator()) {
// Read permission from database, return null if not found // Read permission from database, return null if not found
SystemPermissionModel model = getPermissionMapper().selectOne(targetUser.getModel(), type); SystemPermissionModel model = getPermissionMapper().selectOne(targetUser.getModel(), type);