mirror of
https://github.com/gyurix1968/guacamole-client.git
synced 2025-09-06 13:17:41 +00:00
GUAC-1305: Implement detection of browser WebP support and add new image mimetype to handshake which will include any non-standard image encodings supported.
This commit is contained in:
@@ -183,6 +183,13 @@ public class ConfiguredGuacamoleSocket implements GuacamoleSocket {
|
|||||||
info.getVideoMimetypes().toArray(new String[0])
|
info.getVideoMimetypes().toArray(new String[0])
|
||||||
));
|
));
|
||||||
|
|
||||||
|
// Send supported image formats
|
||||||
|
writer.writeInstruction(
|
||||||
|
new GuacamoleInstruction(
|
||||||
|
"image",
|
||||||
|
info.getImageMimetypes().toArray(new String[0])
|
||||||
|
));
|
||||||
|
|
||||||
// Send args
|
// Send args
|
||||||
writer.writeInstruction(new GuacamoleInstruction("connect", arg_values));
|
writer.writeInstruction(new GuacamoleInstruction("connect", arg_values));
|
||||||
|
|
||||||
|
@@ -55,10 +55,15 @@ public class GuacamoleClientInformation {
|
|||||||
private final List<String> audioMimetypes = new ArrayList<String>();
|
private final List<String> audioMimetypes = new ArrayList<String>();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The list of audio mimetypes reported by the client to be supported.
|
* The list of video mimetypes reported by the client to be supported.
|
||||||
*/
|
*/
|
||||||
private final List<String> videoMimetypes = new ArrayList<String>();
|
private final List<String> videoMimetypes = new ArrayList<String>();
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The list of image mimetypes reported by the client to be supported.
|
||||||
|
*/
|
||||||
|
private final List<String> imageMimetypes = new ArrayList<String>();
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Returns the optimal screen width requested by the client, in pixels.
|
* Returns the optimal screen width requested by the client, in pixels.
|
||||||
* @return The optimal screen width requested by the client, in pixels.
|
* @return The optimal screen width requested by the client, in pixels.
|
||||||
@@ -133,4 +138,15 @@ public class GuacamoleClientInformation {
|
|||||||
return videoMimetypes;
|
return videoMimetypes;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Returns the list of image mimetypes supported by the client. To add or
|
||||||
|
* removed supported mimetypes, the list returned by this function can be
|
||||||
|
* modified.
|
||||||
|
*
|
||||||
|
* @return The set of video mimetypes supported by the client.
|
||||||
|
*/
|
||||||
|
public List<String> getImageMimetypes() {
|
||||||
|
return imageMimetypes;
|
||||||
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
@@ -112,6 +112,11 @@ public class TunnelRequestService {
|
|||||||
if (video_mimetypes != null)
|
if (video_mimetypes != null)
|
||||||
info.getVideoMimetypes().addAll(video_mimetypes);
|
info.getVideoMimetypes().addAll(video_mimetypes);
|
||||||
|
|
||||||
|
// Add image mimetypes
|
||||||
|
List<String> image_mimetypes = request.getParameterValues("image");
|
||||||
|
if (image_mimetypes != null)
|
||||||
|
info.getImageMimetypes().addAll(image_mimetypes);
|
||||||
|
|
||||||
return info;
|
return info;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
63
guacamole/src/main/webapp/app/client/services/guacImage.js
Normal file
63
guacamole/src/main/webapp/app/client/services/guacImage.js
Normal file
@@ -0,0 +1,63 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2015 Glyptodon LLC
|
||||||
|
*
|
||||||
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||||
|
* of this software and associated documentation files (the "Software"), to deal
|
||||||
|
* in the Software without restriction, including without limitation the rights
|
||||||
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||||
|
* copies of the Software, and to permit persons to whom the Software is
|
||||||
|
* furnished to do so, subject to the following conditions:
|
||||||
|
*
|
||||||
|
* The above copyright notice and this permission notice shall be included in
|
||||||
|
* all copies or substantial portions of the Software.
|
||||||
|
*
|
||||||
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||||
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||||
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||||
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||||
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||||
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||||
|
* THE SOFTWARE.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A service for checking browser non-standard image format support for
|
||||||
|
* formats such as Google's WebP.
|
||||||
|
*/
|
||||||
|
|
||||||
|
angular.module('client').factory('guacImage', [function guacImage() {
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Object describing the UI's level of non-standard image format support.
|
||||||
|
*/
|
||||||
|
return new (function () {
|
||||||
|
|
||||||
|
/**
|
||||||
|
* All non-standard image formats to test along with a 1x1 sized
|
||||||
|
* base64 encoded test image.
|
||||||
|
*/
|
||||||
|
var formats = {
|
||||||
|
'image/webp': 'data:image/webp;base64,UklGRhoAAABXRUJQVlA4TA0AAAAvAAAAEAcQERGIiP4HAA==',
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Array of supported (non-standard) image mimetypes.
|
||||||
|
*/
|
||||||
|
this.supported = [];
|
||||||
|
|
||||||
|
// Build array of supported image formats
|
||||||
|
angular.forEach(formats, function(testImgUri, format) {
|
||||||
|
var image = document.createElement("img");
|
||||||
|
image.src = testImgUri;
|
||||||
|
image.onload = image.onerror = (function (_this) {
|
||||||
|
return function() {
|
||||||
|
if (image.width === 1) {
|
||||||
|
_this.supported.push(format);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
})(this);
|
||||||
|
}, this);
|
||||||
|
|
||||||
|
})();
|
||||||
|
|
||||||
|
}]);
|
@@ -42,6 +42,7 @@ angular.module('client').factory('ManagedClient', ['$rootScope', '$injector',
|
|||||||
var connectionService = $injector.get('connectionService');
|
var connectionService = $injector.get('connectionService');
|
||||||
var guacAudio = $injector.get('guacAudio');
|
var guacAudio = $injector.get('guacAudio');
|
||||||
var guacHistory = $injector.get('guacHistory');
|
var guacHistory = $injector.get('guacHistory');
|
||||||
|
var guacImage = $injector.get('guacImage');
|
||||||
var guacVideo = $injector.get('guacVideo');
|
var guacVideo = $injector.get('guacVideo');
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -190,6 +191,11 @@ angular.module('client').factory('ManagedClient', ['$rootScope', '$injector',
|
|||||||
connectString += "&video=" + encodeURIComponent(mimetype);
|
connectString += "&video=" + encodeURIComponent(mimetype);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Add non-standard image mimetypes to connect_string
|
||||||
|
guacImage.supported.forEach(function(mimetype) {
|
||||||
|
connectString += "&image=" + encodeURIComponent(mimetype);
|
||||||
|
});
|
||||||
|
|
||||||
return connectString;
|
return connectString;
|
||||||
|
|
||||||
};
|
};
|
||||||
|
@@ -31,6 +31,9 @@ angular.module('index').controller('indexController', ['$scope', '$injector',
|
|||||||
var $window = $injector.get('$window');
|
var $window = $injector.get('$window');
|
||||||
var guacNotification = $injector.get('guacNotification');
|
var guacNotification = $injector.get('guacNotification');
|
||||||
|
|
||||||
|
// Request guacImage service early as it needs time to load images
|
||||||
|
var guacImage = $injector.get('guacImage');
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The notification service.
|
* The notification service.
|
||||||
*/
|
*/
|
||||||
|
Reference in New Issue
Block a user