From 16cb9ed69b5917a9eeb37b727db287240bcea2af Mon Sep 17 00:00:00 2001
From: Michael Jumper <mjumper@apache.org>
Date: Fri, 21 Jan 2022 15:23:41 -0800
Subject: [PATCH] GUACAMOLE-641: Expand CONNECTION_USERNAME and
 CONNECTION_HOSTNAME tokens only if corresponding parameters are non-empty.

---
 .../guacamole/vault/user/VaultUserContext.java     | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/extensions/guacamole-vault/modules/guacamole-vault-base/src/main/java/org/apache/guacamole/vault/user/VaultUserContext.java b/extensions/guacamole-vault/modules/guacamole-vault-base/src/main/java/org/apache/guacamole/vault/user/VaultUserContext.java
index cf3d99107..a9541aca2 100644
--- a/extensions/guacamole-vault/modules/guacamole-vault-base/src/main/java/org/apache/guacamole/vault/user/VaultUserContext.java
+++ b/extensions/guacamole-vault/modules/guacamole-vault-base/src/main/java/org/apache/guacamole/vault/user/VaultUserContext.java
@@ -77,14 +77,20 @@ public class VaultUserContext extends TokenInjectingUserContext {
     /**
      * The name of the token which will be replaced with the \"hostname\"
      * connection parameter of the current connection if specified within the
-     * name of a secret. This token only applies only to connections.
+     * name of a secret. If the \"hostname\" parameter cannot be retrieved, or
+     * if the parameter is blank, the token will not be replaced and any
+     * secrets involving that token will not be retrieved. This token only
+     * applies only to connections.
      */
     private static final String CONNECTION_HOSTNAME_TOKEN = "CONNECTION_HOSTNAME";
 
     /**
      * The name of the token which will be replaced with the \"username\"
      * connection parameter of the current connection if specified within the
-     * name of a secret. This token only applies only to connections.
+     * name of a secret. If the \"username\" parameter cannot be retrieved, or
+     * if the parameter is blank, the token will not be replaced and any
+     * secrets involving that token will not be retrieved. This token only
+     * applies only to connections.
      */
     private static final String CONNECTION_USERNAME_TOKEN = "CONNECTION_USERNAME";
 
@@ -340,7 +346,7 @@ public class VaultUserContext extends TokenInjectingUserContext {
         Map<String, String> parameters = getConnectionParameters(connection);
 
         String hostname = parameters.get("hostname");
-        if (hostname != null)
+        if (hostname != null && !hostname.isEmpty())
             filter.setToken(CONNECTION_HOSTNAME_TOKEN, hostname);
         else
             logger.debug("Hostname for connection \"{}\" (\"{}\") not "
@@ -349,7 +355,7 @@ public class VaultUserContext extends TokenInjectingUserContext {
                     CONNECTION_HOSTNAME_TOKEN);
 
         String username = parameters.get("username");
-        if (username != null)
+        if (username != null && !username.isEmpty())
             filter.setToken(CONNECTION_USERNAME_TOKEN, username);
         else
             logger.debug("Username for connection \"{}\" (\"{}\") not "