From 1b9f7c51549e2e87a75e4f4a4b3c3ab145a58141 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Wed, 25 Jan 2017 12:40:12 -0500 Subject: [PATCH] GUACAMOLE-47: Fix checking for empty strings; Set tokens to null if nothing found. --- .../org/apache/guacamole/rest/APIRequest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java b/guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java index c1c96128b..5ee31e119 100644 --- a/guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java +++ b/guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java @@ -69,24 +69,24 @@ public class APIRequest extends HttpServletRequestWrapper { super(request); // Try a few methods to get client info. - if(request.getHeader("X-Guacamole-Client-Hostname") != null && request.getHeader("X-Guacamole-Client-Hostname") != "") { + if(request.getHeader("X-Guacamole-Client-Hostname") != null && !request.getHeader("X-Guacamole-Client-Hostname").isEmpty()) { this.remoteHost = request.getHeader("X-Guacamole-Client-Hostname"); - } else if(request.getHeader("X-Forwarded-For") != null && request.getHeader("X-Forwarded-For") != "") { + } else if(request.getHeader("X-Forwarded-For") != null && !request.getHeader("X-Forwarded-For").isEmpty()) { this.remoteHost = request.getHeader("X-Forwarded-For"); - } else if(request.getRemoteHost() != null && request.getRemoteHost() != "") { + } else if(request.getRemoteHost() != null && !request.getRemoteHost().isEmpty()) { this.remoteHost = request.getRemoteHost(); } else { - this.remoteHost = ""; + this.remoteHost = null; } - if(request.getHeader("X-Guacamole-Client-IP") != null && request.getHeader("X-Guacamole-Client-IP") != "") { + if(request.getHeader("X-Guacamole-Client-IP") != null && !request.getHeader("X-Guacamole-Client-IP").isEmpty()) { this.remoteAddr = request.getHeader("X-Guacamole-Client-IP"); - } else if(request.getHeader("X-Forwarded-For") != null && request.getHeader("X-Forwarded-For") != "") { + } else if(request.getHeader("X-Forwarded-For") != null && !request.getHeader("X-Forwarded-For").isEmpty()) { this.remoteAddr = request.getHeader("X-Forwarded-For"); - } else if(request.getRemoteHost() != null && request.getRemoteAddr() != "") { + } else if(request.getRemoteHost() != null && !request.getRemoteAddr().isEmpty()) { this.remoteAddr = request.getRemoteAddr(); } else { - this.remoteAddr = ""; + this.remoteAddr = null; } // Copy parameters from given MultivaluedMap