safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-641: Index records by username ONLY if not related to a hostname.

Browse Source 
Doing otherwise would mean that a particular user would never be able
to be associated with a specific password/key by their username if they
have any explicit server-specific account.
This commit is contained in:
Michael Jumper
2022-01-21 15:23:41 -08:00
parent 87b26fe2c8
commit 1cfd2ee835
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java
View File

@@ -238,10 +238,14 @@ public class KsmClient {
// Store based on UID ...
cachedRecordsByUid.put(record.getRecordUid(), record);
// ... and hostname/address ...
addRecordForHost(record, recordService.getHostname(record));
// ... and hostname/address
String hostname = recordService.getHostname(record);
addRecordForHost(record, hostname);
// ... and username
// Store based on username ONLY if no hostname (will otherwise
// result in ambiguous entries for servers tied to identical
// accounts)
if (hostname == null)
addRecordForLogin(record, recordService.getUsername(record));
});