safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 21:27:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-44: Explicitly define and document the magic 6048-byte blob within ArrayBufferWriter. Allow the blob size to be overridden.

Browse Source
This commit is contained in:
Michael Jumper
2016-06-02 15:40:09 -07:00
parent 3da02bd0a6
commit 2c977a3134
1 changed files with 27 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
guacamole-common-js/src/main/webapp/modules/ArrayBufferWriter.js
View File

@@ -61,6 +61,20 @@ Guacamole.ArrayBufferWriter = function(stream) {
} }
/**
* The maximum length of any blob sent by this Guacamole.ArrayBufferWriter,
* in bytes. Data sent via
* {@link Guacamole.ArrayBufferWriter#sendData|sendData()} which exceeds
* this length will be split into multiple blobs. As the Guacamole protocol
* limits the maximum size of any instruction or instruction element to
* 8192 bytes, and the contents of blobs will be base64-encoded, this value
* should only be increased with extreme caution.
*
* @type {Number}
* @default {@link Guacamole.ArrayBufferWriter.DEFAULT_BLOB_LENGTH}
*/
this.blobLength = Guacamole.ArrayBufferWriter.DEFAULT_BLOB_LENGTH;
/** /**
* Sends the given data. * Sends the given data.
* *
@@ -71,13 +85,13 @@ Guacamole.ArrayBufferWriter = function(stream) {
var bytes = new Uint8Array(data); var bytes = new Uint8Array(data);
// If small enough to fit into single instruction, send as-is // If small enough to fit into single instruction, send as-is
if (bytes.length <= 6048) if (bytes.length <= guac_writer.blobLength)
__send_blob(bytes); __send_blob(bytes);
// Otherwise, send as multiple instructions // Otherwise, send as multiple instructions
else { else {
for (var offset=0; offset<bytes.length; offset += 6048) for (var offset=0; offset<bytes.length; offset += guac_writer.blobLength)
__send_blob(bytes.subarray(offset, offset + 6048)); __send_blob(bytes.subarray(offset, offset + guac_writer.blobLength));
} }
}; };
@@ -97,4 +111,13 @@ Guacamole.ArrayBufferWriter = function(stream) {
*/ */
this.onack = null; this.onack = null;
}; };
/**
* The default maximum blob length for new Guacamole.ArrayBufferWriter
* instances.
*
* @constant
* @type {Number}
*/
Guacamole.ArrayBufferWriter.DEFAULT_BLOB_LENGTH = 6048;