From f1e9ee68760002c41c0c9b42da5abdf1486fe1e5 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Sun, 26 Dec 2021 00:00:24 -0800 Subject: [PATCH] GUACAMOLE-1364: Correct rendering of SSO provider list during invalid login animation. The SSO provider list unexpectedly shrinks when the invalid login "shake" animation plays due to the use of "display: table-row" vs. the login form's own use of "display: table-cell". Migrating the SSO provider list to a simple absolutely-positioned div corrects this and matches the way the Guacamole version is rendered. --- .../src/main/resources/html/sso-providers.html | 6 ++---- .../src/main/resources/styles/sso-providers.css | 15 ++++++++------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/html/sso-providers.html b/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/html/sso-providers.html index bac5f6e33..d089ea292 100644 --- a/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/html/sso-providers.html +++ b/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/html/sso-providers.html @@ -1,7 +1,5 @@
-
- {{ 'LOGIN.SECTION_HEADER_SSO_OPTIONS' | translate }} -
    -
    + {{ 'LOGIN.SECTION_HEADER_SSO_OPTIONS' | translate }} +
    diff --git a/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/styles/sso-providers.css b/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/styles/sso-providers.css index 27eae1ea7..0a97446ec 100644 --- a/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/styles/sso-providers.css +++ b/extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/styles/sso-providers.css @@ -18,11 +18,18 @@ */ .login-ui .sso-providers { + + padding: 0.25em 0.5em; + position: absolute; + bottom: 0; + left: 0; + display: none; + } .login-ui .sso-providers:last-child { - display: table-row; + display: block; } .sso-providers ul { @@ -42,9 +49,3 @@ .sso-providers li:first-child::before { display: none; } - -.sso-providers-content { - display: table-cell; - padding: 0.25em 0.5em; - height: 1px; -}