From 3ec578edce9fb697ba06014e257a233e6b612c67 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Wed, 2 Jun 2021 16:08:47 -0700 Subject: [PATCH] GUACAMOLE-773: Remove angular-touch (no longer applicable). Previously, the angular-touch library provided by AngularJS was used to allow click interactions with UI components to work on touch devices without an uncomfortable ~300ms delay. From AngularJS 1.7.x onward, this feature of angular-touch is no longer present: https://docs.angularjs.org/guide/migration#ngtouch This should be OK - modern browsers will now recognize applications aimed at touch support via the use of the "viewport" meta tag (which we use), removing our original need for angular-touch. The same goes for IE10+. --- doc/licenses/angular-1.8.2/dep-coordinates.txt | 1 - guacamole/src/main/frontend/package-lock.json | 5 ----- guacamole/src/main/frontend/package.json | 1 - guacamole/src/main/frontend/src/app/index/indexModule.js | 1 - 4 files changed, 8 deletions(-) diff --git a/doc/licenses/angular-1.8.2/dep-coordinates.txt b/doc/licenses/angular-1.8.2/dep-coordinates.txt index d6307c825..9747e3027 100644 --- a/doc/licenses/angular-1.8.2/dep-coordinates.txt +++ b/doc/licenses/angular-1.8.2/dep-coordinates.txt @@ -1,3 +1,2 @@ angular-route:1.8.2 -angular-touch:1.8.2 angular:1.8.2 diff --git a/guacamole/src/main/frontend/package-lock.json b/guacamole/src/main/frontend/package-lock.json index 2d9ec9872..97434a3e0 100644 --- a/guacamole/src/main/frontend/package-lock.json +++ b/guacamole/src/main/frontend/package-lock.json @@ -544,11 +544,6 @@ } } }, - "angular-touch": { - "version": "1.8.2", - "resolved": "https://registry.npmjs.org/angular-touch/-/angular-touch-1.8.2.tgz", - "integrity": "sha512-tGoFNsONm/VHFcBW8gySVZvpCIYAvsAlEuHpJDugGn+3ENLxSDhpZ4ikev4KXfWr8ZNsYGoVSfsvJegkiC+9Ig==" - }, "angular-translate": { "version": "2.18.4", "resolved": "https://registry.npmjs.org/angular-translate/-/angular-translate-2.18.4.tgz", diff --git a/guacamole/src/main/frontend/package.json b/guacamole/src/main/frontend/package.json index faccbe09b..c8dc5948a 100644 --- a/guacamole/src/main/frontend/package.json +++ b/guacamole/src/main/frontend/package.json @@ -8,7 +8,6 @@ "angular": "1.8.2", "angular-route": "1.8.2", "angular-templatecache-webpack-plugin": "^1.0.1", - "angular-touch": "1.8.2", "angular-translate": "2.18.4", "angular-translate-interpolation-messageformat": "2.18.4", "angular-translate-loader-static-files": "2.18.4", diff --git a/guacamole/src/main/frontend/src/app/index/indexModule.js b/guacamole/src/main/frontend/src/app/index/indexModule.js index 2b74ecd06..e0281f439 100644 --- a/guacamole/src/main/frontend/src/app/index/indexModule.js +++ b/guacamole/src/main/frontend/src/app/index/indexModule.js @@ -29,7 +29,6 @@ require('angular-translate-loader-static-files'); angular.module('index', [ require('angular-route'), - require('angular-touch'), require('angular-translate'), 'auth',