safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-10-31 09:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-267: Avoid unnecessarily rebuilding the Guacamole protocol form of a GuacamoleInstruction.

Browse Source
This commit is contained in:
Michael Jumper
2017-04-16 21:02:00 -07:00
parent 798f06ee0a
commit 3f38880a12
1 changed files with 34 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
guacamole-common/src/main/java/org/apache/guacamole/protocol/GuacamoleInstruction.java
View File

@@ -33,12 +33,18 @@ public class GuacamoleInstruction {
/**
* The opcode of this instruction.
*/
private String opcode;
private final String opcode;
/**
* All arguments of this instruction, in order.
*/
private List<String> args;
private final List<String> args;
/**
* The cached result of converting this GuacamoleInstruction to the format
* used by the Guacamole protocol.
*/
private String protocolForm = null;
/**
* Creates a new GuacamoleInstruction having the given Operation and
@@ -91,31 +97,41 @@ public class GuacamoleInstruction {
* Returns this GuacamoleInstruction in the form it would be sent over the
* Guacamole protocol.
*
* @return This GuacamoleInstruction in the form it would be sent over the
* Guacamole protocol.
* @return
* This GuacamoleInstruction in the form it would be sent over the
* Guacamole protocol.
*/
@Override
public String toString() {
StringBuilder buff = new StringBuilder();
// Avoid rebuilding Guacamole protocol form of instruction if already
// known
if (protocolForm == null) {
// Write opcode
buff.append(opcode.length());
buff.append('.');
buff.append(opcode);
StringBuilder buff = new StringBuilder();
// Write argument values
for (String value : args) {
buff.append(',');
buff.append(value.length());
// Write opcode
buff.append(opcode.length());
buff.append('.');
buff.append(value);
buff.append(opcode);
// Write argument values
for (String value : args) {
buff.append(',');
buff.append(value.length());
buff.append('.');
buff.append(value);
}
// Write terminator
buff.append(';');
// Cache result for future calls
protocolForm = buff.toString();
}
// Write terminator
buff.append(';');
return buff.toString();
return protocolForm;
}