From 50baf1c9474f60e7099821e0e395a14458bbb700 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Fri, 22 Jun 2018 06:43:56 -0400 Subject: [PATCH] GUACAMOLE-580: Avert potential NullPointerException when looking for user attributes. --- .../guacamole/auth/ldap/AuthenticationProviderService.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java index 547b71db5..cd3ac37ed 100644 --- a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java +++ b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java @@ -26,6 +26,7 @@ import com.novell.ldap.LDAPAttributeSet; import com.novell.ldap.LDAPConnection; import com.novell.ldap.LDAPEntry; import com.novell.ldap.LDAPException; +import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -283,7 +284,12 @@ public class AuthenticationProviderService { try { // Get LDAP attributes by querying LDAP LDAPEntry userEntry = ldapConnection.read(userDN, attrArray); + if (userEntry == null) + return null; + LDAPAttributeSet attrSet = userEntry.getAttributeSet(); + if (attrSet == null) + return null; // Add each attribute into Map for (Object attrObj : attrSet) {