From 544b3c6767c72638057c161b8b7ae43b02a85e90 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Thu, 28 Jul 2016 21:45:56 -0700 Subject: [PATCH] GUACAMOLE-5: Clarify the JDBC-specific implementation of AuthenticatedUser. --- .../ActiveConnectionPermissionService.java | 14 ++++---- .../ActiveConnectionService.java | 14 ++++---- .../TrackedActiveConnection.java | 4 +-- .../jdbc/base/DirectoryObjectService.java | 14 ++++---- .../base/ModeledDirectoryObjectService.java | 34 +++++++++---------- .../ModeledGroupedDirectoryObjectService.java | 12 +++---- .../auth/jdbc/base/ModeledObject.java | 4 +-- .../auth/jdbc/base/RestrictedObject.java | 10 +++--- .../jdbc/connection/ConnectionService.java | 28 +++++++-------- .../ModeledGuacamoleConfiguration.java | 6 ++-- .../ConnectionGroupService.java | 18 +++++----- .../permission/AbstractPermissionService.java | 4 +-- .../ConnectionGroupPermissionService.java | 4 +-- .../ConnectionPermissionService.java | 4 +-- .../ModeledObjectPermissionService.java | 12 +++---- .../permission/ModeledPermissionService.java | 4 +-- .../permission/ObjectPermissionService.java | 6 ++-- .../jdbc/permission/ObjectPermissionSet.java | 4 +-- .../jdbc/permission/PermissionService.java | 10 +++--- .../SharingProfilePermissionService.java | 4 +-- .../permission/SystemPermissionService.java | 10 +++--- .../jdbc/permission/SystemPermissionSet.java | 4 +-- .../permission/UserPermissionService.java | 4 +-- .../sharing/ConnectionSharingService.java | 4 +-- .../sharingprofile/SharingProfileService.java | 22 ++++++------ .../AbstractGuacamoleTunnelService.java | 12 +++---- .../jdbc/tunnel/GuacamoleTunnelService.java | 8 ++--- ...ser.java => ModeledAuthenticatedUser.java} | 11 +++--- .../guacamole/auth/jdbc/user/UserContext.java | 2 +- .../guacamole/auth/jdbc/user/UserService.java | 29 ++++++++-------- 30 files changed, 160 insertions(+), 156 deletions(-) rename extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/{AuthenticatedUser.java => ModeledAuthenticatedUser.java} (93%) diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionPermissionService.java index 68bd297a4..efb24e610 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionPermissionService.java @@ -32,7 +32,7 @@ import org.apache.guacamole.auth.jdbc.permission.AbstractPermissionService; import org.apache.guacamole.auth.jdbc.permission.ObjectPermissionService; import org.apache.guacamole.auth.jdbc.tunnel.ActiveConnectionRecord; import org.apache.guacamole.auth.jdbc.tunnel.GuacamoleTunnelService; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.net.auth.permission.ObjectPermission; import org.apache.guacamole.net.auth.permission.ObjectPermissionSet; @@ -60,7 +60,7 @@ public class ActiveConnectionPermissionService private Provider activeConnectionPermissionSetProvider; @Override - public ObjectPermission retrievePermission(AuthenticatedUser user, + public ObjectPermission retrievePermission(ModeledAuthenticatedUser user, ModeledUser targetUser, ObjectPermission.Type type, String identifier) throws GuacamoleException { @@ -78,7 +78,7 @@ public class ActiveConnectionPermissionService } @Override - public Set retrievePermissions(AuthenticatedUser user, + public Set retrievePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Retrieve permissions only if allowed @@ -113,7 +113,7 @@ public class ActiveConnectionPermissionService } @Override - public Collection retrieveAccessibleIdentifiers(AuthenticatedUser user, + public Collection retrieveAccessibleIdentifiers(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissionTypes, Collection identifiers) throws GuacamoleException { @@ -139,7 +139,7 @@ public class ActiveConnectionPermissionService } @Override - public ObjectPermissionSet getPermissionSet(AuthenticatedUser user, + public ObjectPermissionSet getPermissionSet(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Create permission set for requested user @@ -151,7 +151,7 @@ public class ActiveConnectionPermissionService } @Override - public void createPermissions(AuthenticatedUser user, + public void createPermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { @@ -161,7 +161,7 @@ public class ActiveConnectionPermissionService } @Override - public void deletePermissions(AuthenticatedUser user, + public void deletePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java index 1fc438a57..56405269f 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java @@ -26,7 +26,7 @@ import java.util.Collection; import java.util.Collections; import java.util.HashSet; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; import org.apache.guacamole.auth.jdbc.base.DirectoryObjectService; @@ -57,7 +57,7 @@ public class ActiveConnectionService private Provider trackedActiveConnectionProvider; @Override - public TrackedActiveConnection retrieveObject(AuthenticatedUser user, + public TrackedActiveConnection retrieveObject(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException { // Pull objects having given identifier @@ -77,7 +77,7 @@ public class ActiveConnectionService } @Override - public Collection retrieveObjects(AuthenticatedUser user, + public Collection retrieveObjects(ModeledAuthenticatedUser user, Collection identifiers) throws GuacamoleException { String username = user.getIdentifier(); @@ -110,7 +110,7 @@ public class ActiveConnectionService } @Override - public void deleteObject(AuthenticatedUser user, String identifier) + public void deleteObject(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException { // Only administrators may delete active connections @@ -131,7 +131,7 @@ public class ActiveConnectionService } @Override - public Set getIdentifiers(AuthenticatedUser user) + public Set getIdentifiers(ModeledAuthenticatedUser user) throws GuacamoleException { // Retrieve all visible connections (permissions enforced by tunnel service) @@ -147,7 +147,7 @@ public class ActiveConnectionService } @Override - public TrackedActiveConnection createObject(AuthenticatedUser user, + public TrackedActiveConnection createObject(ModeledAuthenticatedUser user, ActiveConnection object) throws GuacamoleException { // Updating active connections is not implemented @@ -156,7 +156,7 @@ public class ActiveConnectionService } @Override - public void updateObject(AuthenticatedUser user, TrackedActiveConnection object) + public void updateObject(ModeledAuthenticatedUser user, TrackedActiveConnection object) throws GuacamoleException { // Updating active connections is not implemented diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/TrackedActiveConnection.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/TrackedActiveConnection.java index 29243f4d1..642805d38 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/TrackedActiveConnection.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/TrackedActiveConnection.java @@ -26,7 +26,7 @@ import org.apache.guacamole.auth.jdbc.base.RestrictedObject; import org.apache.guacamole.auth.jdbc.connection.ModeledConnection; import org.apache.guacamole.auth.jdbc.sharing.ConnectionSharingService; import org.apache.guacamole.auth.jdbc.tunnel.ActiveConnectionRecord; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.net.GuacamoleTunnel; import org.apache.guacamole.net.auth.ActiveConnection; import org.apache.guacamole.net.auth.credentials.UserCredentials; @@ -105,7 +105,7 @@ public class TrackedActiveConnection extends RestrictedObject implements ActiveC * as well. This includes the remote host, associated tunnel, and * username. */ - public void init(AuthenticatedUser currentUser, + public void init(ModeledAuthenticatedUser currentUser, ActiveConnectionRecord activeConnectionRecord, boolean includeSensitiveInformation) { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/DirectoryObjectService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/DirectoryObjectService.java index 11ef2a4e1..987752110 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/DirectoryObjectService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/DirectoryObjectService.java @@ -21,7 +21,7 @@ package org.apache.guacamole.auth.jdbc.base; import java.util.Collection; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; /** @@ -58,7 +58,7 @@ public interface DirectoryObjectService { * @throws GuacamoleException * If an error occurs while retrieving the requested object. */ - InternalType retrieveObject(AuthenticatedUser user, String identifier) + InternalType retrieveObject(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException; /** @@ -77,7 +77,7 @@ public interface DirectoryObjectService { * @throws GuacamoleException * If an error occurs while retrieving the requested objects. */ - Collection retrieveObjects(AuthenticatedUser user, + Collection retrieveObjects(ModeledAuthenticatedUser user, Collection identifiers) throws GuacamoleException; /** @@ -97,7 +97,7 @@ public interface DirectoryObjectService { * If the user lacks permission to create the object, or an error * occurs while creating the object. */ - InternalType createObject(AuthenticatedUser user, ExternalType object) + InternalType createObject(ModeledAuthenticatedUser user, ExternalType object) throws GuacamoleException; /** @@ -114,7 +114,7 @@ public interface DirectoryObjectService { * If the user lacks permission to delete the object, or an error * occurs while deleting the object. */ - void deleteObject(AuthenticatedUser user, String identifier) + void deleteObject(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException; /** @@ -131,7 +131,7 @@ public interface DirectoryObjectService { * If the user lacks permission to update the object, or an error * occurs while updating the object. */ - void updateObject(AuthenticatedUser user, InternalType object) + void updateObject(ModeledAuthenticatedUser user, InternalType object) throws GuacamoleException; /** @@ -147,6 +147,6 @@ public interface DirectoryObjectService { * @throws GuacamoleException * If an error occurs while reading identifiers. */ - Set getIdentifiers(AuthenticatedUser user) throws GuacamoleException; + Set getIdentifiers(ModeledAuthenticatedUser user) throws GuacamoleException; } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java index 4e1c1f59c..f2d2e50bf 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java @@ -24,7 +24,7 @@ import java.util.Collection; import java.util.Collections; import java.util.Set; import javax.xml.stream.events.Characters; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; import org.apache.guacamole.auth.jdbc.permission.ObjectPermissionMapper; @@ -100,7 +100,7 @@ public abstract class ModeledDirectoryObjectService getObjectInstances(AuthenticatedUser currentUser, + protected Collection getObjectInstances(ModeledAuthenticatedUser currentUser, Collection models) { // Create new collection of objects by manually converting each model @@ -230,7 +230,7 @@ public abstract class ModeledDirectoryObjectService retrieveObjects(AuthenticatedUser user, + public Collection retrieveObjects(ModeledAuthenticatedUser user, Collection identifiers) throws GuacamoleException { // Ignore invalid identifiers @@ -350,7 +350,7 @@ public abstract class ModeledDirectoryObjectService getImplicitPermissions(AuthenticatedUser user, + protected Collection getImplicitPermissions(ModeledAuthenticatedUser user, ModelType model) { // Build list of implicit permissions @@ -377,7 +377,7 @@ public abstract class ModeledDirectoryObjectService getIdentifiers(AuthenticatedUser user) + public Set getIdentifiers(ModeledAuthenticatedUser user) throws GuacamoleException { // Bypass permission checks if the user is a system admin diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledGroupedDirectoryObjectService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledGroupedDirectoryObjectService.java index 4aecff22c..718def70a 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledGroupedDirectoryObjectService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledGroupedDirectoryObjectService.java @@ -24,7 +24,7 @@ import java.util.Collection; import java.util.Collections; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.net.auth.Identifiable; import org.apache.guacamole.net.auth.permission.ObjectPermission; import org.apache.guacamole.net.auth.permission.ObjectPermissionSet; @@ -76,7 +76,7 @@ public abstract class ModeledGroupedDirectoryObjectService getModifiedGroups(AuthenticatedUser user, + protected Collection getModifiedGroups(ModeledAuthenticatedUser user, String identifier, ModelType model) throws GuacamoleException { // Get old parent identifier @@ -130,7 +130,7 @@ public abstract class ModeledGroupedDirectoryObjectService extends RestrictedObject { * @param model * The backing model object. */ - public void init(AuthenticatedUser currentUser, ModelType model) { + public void init(ModeledAuthenticatedUser currentUser, ModelType model) { super.init(currentUser); setModel(model); } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RestrictedObject.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RestrictedObject.java index 06eb29619..9bcc8ed4a 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RestrictedObject.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/RestrictedObject.java @@ -19,7 +19,7 @@ package org.apache.guacamole.auth.jdbc.base; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; /** * Common base class for objects that are associated with the users that @@ -33,7 +33,7 @@ public abstract class RestrictedObject { * The user this object belongs to. Access is based on his/her permission * settings. */ - private AuthenticatedUser currentUser; + private ModeledAuthenticatedUser currentUser; /** * Initializes this object, associating it with the current authenticated @@ -42,7 +42,7 @@ public abstract class RestrictedObject { * @param currentUser * The user that created or retrieved this object. */ - public void init(AuthenticatedUser currentUser) { + public void init(ModeledAuthenticatedUser currentUser) { setCurrentUser(currentUser); } @@ -54,7 +54,7 @@ public abstract class RestrictedObject { * @return * The user that created or queried this object. */ - public AuthenticatedUser getCurrentUser() { + public ModeledAuthenticatedUser getCurrentUser() { return currentUser; } @@ -66,7 +66,7 @@ public abstract class RestrictedObject { * @param currentUser * The user that created or queried this object. */ - public void setCurrentUser(AuthenticatedUser currentUser) { + public void setCurrentUser(ModeledAuthenticatedUser currentUser) { this.currentUser = currentUser; } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionService.java index 70bffbb98..cf64f8a2c 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionService.java @@ -28,7 +28,7 @@ import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.base.ModeledDirectoryObjectMapper; import org.apache.guacamole.auth.jdbc.tunnel.GuacamoleTunnelService; import org.apache.guacamole.GuacamoleClientException; @@ -101,7 +101,7 @@ public class ConnectionService extends ModeledGroupedDirectoryObjectService getIdentifiersWithin(AuthenticatedUser user, + public Set getIdentifiersWithin(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException { @@ -313,7 +313,7 @@ public class ConnectionService extends ModeledGroupedDirectoryObjectService retrieveParameters(AuthenticatedUser user, + public Map retrieveParameters(ModeledAuthenticatedUser user, String identifier) { Map parameterMap = new HashMap(); @@ -394,7 +394,7 @@ public class ConnectionService extends ModeledGroupedDirectoryObjectService retrieveHistory(AuthenticatedUser user, + public List retrieveHistory(ModeledAuthenticatedUser user, ModeledConnection connection) throws GuacamoleException { String identifier = connection.getIdentifier(); @@ -450,7 +450,7 @@ public class ConnectionService extends ModeledGroupedDirectoryObjectService retrieveHistory(AuthenticatedUser user, + public List retrieveHistory(ModeledAuthenticatedUser user, Collection requiredContents, List sortPredicates, int limit) throws GuacamoleException { @@ -492,7 +492,7 @@ public class ConnectionService extends ModeledGroupedDirectoryObjectService getIdentifiersWithin(AuthenticatedUser user, + public Set getIdentifiersWithin(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException { @@ -239,7 +239,7 @@ public class ConnectionGroupService extends ModeledGroupedDirectoryObjectService * @throws GuacamoleException * If permission to connect to this connection is denied. */ - public GuacamoleTunnel connect(AuthenticatedUser user, + public GuacamoleTunnel connect(ModeledAuthenticatedUser user, ModeledConnectionGroup connectionGroup, GuacamoleClientInformation info) throws GuacamoleException { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/AbstractPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/AbstractPermissionService.java index 081010486..d4a27c613 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/AbstractPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/AbstractPermissionService.java @@ -19,7 +19,7 @@ package org.apache.guacamole.auth.jdbc.permission; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.net.auth.permission.ObjectPermission; @@ -61,7 +61,7 @@ public abstract class AbstractPermissionService permissions) throws GuacamoleException { @@ -123,7 +123,7 @@ public abstract class ModeledObjectPermissionService } @Override - public void createPermissions(AuthenticatedUser user, ModeledUser targetUser, + public void createPermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { @@ -140,7 +140,7 @@ public abstract class ModeledObjectPermissionService } @Override - public void deletePermissions(AuthenticatedUser user, ModeledUser targetUser, + public void deletePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { @@ -157,7 +157,7 @@ public abstract class ModeledObjectPermissionService } @Override - public ObjectPermission retrievePermission(AuthenticatedUser user, + public ObjectPermission retrievePermission(ModeledAuthenticatedUser user, ModeledUser targetUser, ObjectPermission.Type type, String identifier) throws GuacamoleException { @@ -179,7 +179,7 @@ public abstract class ModeledObjectPermissionService } @Override - public Collection retrieveAccessibleIdentifiers(AuthenticatedUser user, + public Collection retrieveAccessibleIdentifiers(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions, Collection identifiers) throws GuacamoleException { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ModeledPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ModeledPermissionService.java index aaa090955..54155320f 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ModeledPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ModeledPermissionService.java @@ -23,7 +23,7 @@ import java.util.ArrayList; import java.util.Collection; import java.util.HashSet; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; @@ -140,7 +140,7 @@ public abstract class ModeledPermissionService retrievePermissions(AuthenticatedUser user, + public Set retrievePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Retrieve permissions only if allowed diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionService.java index 42bd7ce48..4a92cb2b7 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionService.java @@ -20,7 +20,7 @@ package org.apache.guacamole.auth.jdbc.permission; import java.util.Collection; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.net.auth.permission.ObjectPermission; @@ -59,7 +59,7 @@ public interface ObjectPermissionService * @throws GuacamoleException * If an error occurs while retrieving the requested permission. */ - ObjectPermission retrievePermission(AuthenticatedUser user, + ObjectPermission retrievePermission(ModeledAuthenticatedUser user, ModeledUser targetUser, ObjectPermission.Type type, String identifier) throws GuacamoleException; @@ -89,7 +89,7 @@ public interface ObjectPermissionService * @throws GuacamoleException * If an error occurs while retrieving permissions. */ - Collection retrieveAccessibleIdentifiers(AuthenticatedUser user, + Collection retrieveAccessibleIdentifiers(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions, Collection identifiers) throws GuacamoleException; diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionSet.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionSet.java index 5e9c95c61..e210fd1c6 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionSet.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/ObjectPermissionSet.java @@ -23,7 +23,7 @@ import org.apache.guacamole.auth.jdbc.user.ModeledUser; import java.util.Collection; import java.util.Collections; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.auth.jdbc.base.RestrictedObject; import org.apache.guacamole.net.auth.permission.ObjectPermission; @@ -63,7 +63,7 @@ public abstract class ObjectPermissionSet extends RestrictedObject * @param user * The user to whom the permissions in this set are granted. */ - public void init(AuthenticatedUser currentUser, ModeledUser user) { + public void init(ModeledAuthenticatedUser currentUser, ModeledUser user) { super.init(currentUser); this.user = user; } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/PermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/PermissionService.java index e61194690..d9e9c9702 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/PermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/PermissionService.java @@ -23,7 +23,7 @@ import java.util.ArrayList; import java.util.Collection; import java.util.HashSet; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; @@ -69,7 +69,7 @@ public interface PermissionService retrievePermissions(AuthenticatedUser user, + Set retrievePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException; /** @@ -107,7 +107,7 @@ public interface PermissionService permissions) throws GuacamoleException; /** @@ -127,7 +127,7 @@ public interface PermissionService permissions) throws GuacamoleException; } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SharingProfilePermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SharingProfilePermissionService.java index 7c12afd20..9eeb6c979 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SharingProfilePermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SharingProfilePermissionService.java @@ -21,7 +21,7 @@ package org.apache.guacamole.auth.jdbc.permission; import com.google.inject.Inject; import com.google.inject.Provider; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.auth.jdbc.user.ModeledUser; @@ -52,7 +52,7 @@ public class SharingProfilePermissionService extends ModeledObjectPermissionServ } @Override - public ObjectPermissionSet getPermissionSet(AuthenticatedUser user, + public ObjectPermissionSet getPermissionSet(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Create permission set for requested user diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionService.java index 78c25eb39..23a378522 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionService.java @@ -22,7 +22,7 @@ package org.apache.guacamole.auth.jdbc.permission; import com.google.inject.Inject; import com.google.inject.Provider; import java.util.Collection; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.user.ModeledUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; @@ -77,7 +77,7 @@ public class SystemPermissionService } @Override - public SystemPermissionSet getPermissionSet(AuthenticatedUser user, + public SystemPermissionSet getPermissionSet(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Create permission set for requested user @@ -89,7 +89,7 @@ public class SystemPermissionService } @Override - public void createPermissions(AuthenticatedUser user, ModeledUser targetUser, + public void createPermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { // Only an admin can create system permissions @@ -105,7 +105,7 @@ public class SystemPermissionService } @Override - public void deletePermissions(AuthenticatedUser user, ModeledUser targetUser, + public void deletePermissions(ModeledAuthenticatedUser user, ModeledUser targetUser, Collection permissions) throws GuacamoleException { // Only an admin can delete system permissions @@ -145,7 +145,7 @@ public class SystemPermissionService * @throws GuacamoleException * If an error occurs while retrieving the requested permission. */ - public SystemPermission retrievePermission(AuthenticatedUser user, + public SystemPermission retrievePermission(ModeledAuthenticatedUser user, ModeledUser targetUser, SystemPermission.Type type) throws GuacamoleException { // Retrieve permissions only if allowed diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionSet.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionSet.java index cbdd565fa..25019dfd3 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionSet.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/SystemPermissionSet.java @@ -23,7 +23,7 @@ import org.apache.guacamole.auth.jdbc.user.ModeledUser; import com.google.inject.Inject; import java.util.Collections; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.auth.jdbc.base.RestrictedObject; import org.apache.guacamole.net.auth.permission.SystemPermission; @@ -69,7 +69,7 @@ public class SystemPermissionSet extends RestrictedObject * @param user * The user to whom the permissions in this set are granted. */ - public void init(AuthenticatedUser currentUser, ModeledUser user) { + public void init(ModeledAuthenticatedUser currentUser, ModeledUser user) { super.init(currentUser); this.user = user; } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/UserPermissionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/UserPermissionService.java index 8a81c8965..0957339f6 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/UserPermissionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/UserPermissionService.java @@ -21,7 +21,7 @@ package org.apache.guacamole.auth.jdbc.permission; import com.google.inject.Inject; import com.google.inject.Provider; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.auth.jdbc.user.ModeledUser; @@ -52,7 +52,7 @@ public class UserPermissionService extends ModeledObjectPermissionService { } @Override - public ObjectPermissionSet getPermissionSet(AuthenticatedUser user, + public ObjectPermissionSet getPermissionSet(ModeledAuthenticatedUser user, ModeledUser targetUser) throws GuacamoleException { // Create permission set for requested user diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing/ConnectionSharingService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing/ConnectionSharingService.java index a3f8a23bc..40de6e32a 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing/ConnectionSharingService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharing/ConnectionSharingService.java @@ -22,7 +22,7 @@ package org.apache.guacamole.auth.jdbc.sharing; import com.google.inject.Inject; import java.util.Collections; import javax.servlet.http.HttpServletRequest; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleSecurityException; import org.apache.guacamole.auth.jdbc.sharingprofile.ModeledSharingProfile; @@ -97,7 +97,7 @@ public class ConnectionSharingService { * @throws GuacamoleException * If permission to share the given connection is denied. */ - public UserCredentials generateTemporaryCredentials(AuthenticatedUser user, + public UserCredentials generateTemporaryCredentials(ModeledAuthenticatedUser user, ActiveConnectionRecord activeConnection, String sharingProfileIdentifier) throws GuacamoleException { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharingprofile/SharingProfileService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharingprofile/SharingProfileService.java index 11c70d23a..ec12929a1 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharingprofile/SharingProfileService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/sharingprofile/SharingProfileService.java @@ -26,7 +26,7 @@ import java.util.Collection; import java.util.HashMap; import java.util.Map; import java.util.Set; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.base.ModeledDirectoryObjectMapper; import org.apache.guacamole.GuacamoleClientException; import org.apache.guacamole.GuacamoleException; @@ -84,7 +84,7 @@ public class SharingProfileService } @Override - protected ModeledSharingProfile getObjectInstance(AuthenticatedUser currentUser, + protected ModeledSharingProfile getObjectInstance(ModeledAuthenticatedUser currentUser, SharingProfileModel model) { ModeledSharingProfile sharingProfile = sharingProfileProvider.get(); sharingProfile.init(currentUser, model); @@ -92,7 +92,7 @@ public class SharingProfileService } @Override - protected SharingProfileModel getModelInstance(AuthenticatedUser currentUser, + protected SharingProfileModel getModelInstance(ModeledAuthenticatedUser currentUser, final SharingProfile object) { // Create new ModeledSharingProfile backed by blank model @@ -111,7 +111,7 @@ public class SharingProfileService } @Override - protected boolean hasCreatePermission(AuthenticatedUser user) + protected boolean hasCreatePermission(ModeledAuthenticatedUser user) throws GuacamoleException { // Return whether user has explicit sharing profile creation permission @@ -121,7 +121,7 @@ public class SharingProfileService } @Override - protected ObjectPermissionSet getPermissionSet(AuthenticatedUser user) + protected ObjectPermissionSet getPermissionSet(ModeledAuthenticatedUser user) throws GuacamoleException { // Return permissions related to sharing profiles @@ -130,7 +130,7 @@ public class SharingProfileService } @Override - protected void beforeCreate(AuthenticatedUser user, + protected void beforeCreate(ModeledAuthenticatedUser user, SharingProfileModel model) throws GuacamoleException { super.beforeCreate(user, model); @@ -147,7 +147,7 @@ public class SharingProfileService } @Override - protected void beforeUpdate(AuthenticatedUser user, + protected void beforeUpdate(ModeledAuthenticatedUser user, SharingProfileModel model) throws GuacamoleException { super.beforeUpdate(user, model); @@ -213,7 +213,7 @@ public class SharingProfileService } @Override - public ModeledSharingProfile createObject(AuthenticatedUser user, SharingProfile object) + public ModeledSharingProfile createObject(ModeledAuthenticatedUser user, SharingProfile object) throws GuacamoleException { // Create sharing profile @@ -230,7 +230,7 @@ public class SharingProfileService } @Override - public void updateObject(AuthenticatedUser user, ModeledSharingProfile object) + public void updateObject(ModeledAuthenticatedUser user, ModeledSharingProfile object) throws GuacamoleException { // Update sharing profile @@ -266,7 +266,7 @@ public class SharingProfileService * @throws GuacamoleException * If an error occurs while reading identifiers. */ - public Set getIdentifiersWithin(AuthenticatedUser user, + public Set getIdentifiersWithin(ModeledAuthenticatedUser user, String identifier) throws GuacamoleException { @@ -298,7 +298,7 @@ public class SharingProfileService * A new map of all parameter name/value pairs that the given user has * access to. */ - public Map retrieveParameters(AuthenticatedUser user, + public Map retrieveParameters(ModeledAuthenticatedUser user, String identifier) { Map parameterMap = new HashMap(); diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java index 85206eb5b..6ec329b3f 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java @@ -31,7 +31,7 @@ import java.util.Map; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.atomic.AtomicBoolean; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.connection.ModeledConnection; import org.apache.guacamole.auth.jdbc.connectiongroup.ModeledConnectionGroup; import org.apache.guacamole.auth.jdbc.connection.ConnectionRecordMapper; @@ -522,7 +522,7 @@ public abstract class AbstractGuacamoleTunnelService implements GuacamoleTunnelS * provided identifiers are preferred, the original collection of * identifiers. */ - private Collection getPreferredConnections(AuthenticatedUser user, + private Collection getPreferredConnections(ModeledAuthenticatedUser user, Collection identifiers) { // Search provided identifiers for any preferred connections @@ -556,7 +556,7 @@ public abstract class AbstractGuacamoleTunnelService implements GuacamoleTunnelS * A list containing all balanced connections within the given group, * or an empty list if there are no such connections. */ - private List getBalancedConnections(AuthenticatedUser user, + private List getBalancedConnections(ModeledAuthenticatedUser user, ModeledConnectionGroup connectionGroup) { // If not a balancing group, there are no balanced connections @@ -588,7 +588,7 @@ public abstract class AbstractGuacamoleTunnelService implements GuacamoleTunnelS } @Override - public Collection getActiveConnections(AuthenticatedUser user) + public Collection getActiveConnections(ModeledAuthenticatedUser user) throws GuacamoleException { // Simply return empty list if there are no active tunnels @@ -626,7 +626,7 @@ public abstract class AbstractGuacamoleTunnelService implements GuacamoleTunnelS @Override @Transactional - public GuacamoleTunnel getGuacamoleTunnel(final AuthenticatedUser user, + public GuacamoleTunnel getGuacamoleTunnel(final ModeledAuthenticatedUser user, final ModeledConnection connection, GuacamoleClientInformation info) throws GuacamoleException { @@ -647,7 +647,7 @@ public abstract class AbstractGuacamoleTunnelService implements GuacamoleTunnelS @Override @Transactional - public GuacamoleTunnel getGuacamoleTunnel(AuthenticatedUser user, + public GuacamoleTunnel getGuacamoleTunnel(ModeledAuthenticatedUser user, ModeledConnectionGroup connectionGroup, GuacamoleClientInformation info) throws GuacamoleException { diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/GuacamoleTunnelService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/GuacamoleTunnelService.java index 34965a7b9..5ba171833 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/GuacamoleTunnelService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/GuacamoleTunnelService.java @@ -20,7 +20,7 @@ package org.apache.guacamole.auth.jdbc.tunnel; import java.util.Collection; -import org.apache.guacamole.auth.jdbc.user.AuthenticatedUser; +import org.apache.guacamole.auth.jdbc.user.ModeledAuthenticatedUser; import org.apache.guacamole.auth.jdbc.connection.ModeledConnection; import org.apache.guacamole.auth.jdbc.connectiongroup.ModeledConnectionGroup; import org.apache.guacamole.GuacamoleException; @@ -55,7 +55,7 @@ public interface GuacamoleTunnelService { * If an error occurs while retrieving all active connections, or if * permission is denied. */ - public Collection getActiveConnections(AuthenticatedUser user) + public Collection getActiveConnections(ModeledAuthenticatedUser user) throws GuacamoleException; /** @@ -83,7 +83,7 @@ public interface GuacamoleTunnelService { * If the connection cannot be established due to concurrent usage * rules. */ - GuacamoleTunnel getGuacamoleTunnel(AuthenticatedUser user, + GuacamoleTunnel getGuacamoleTunnel(ModeledAuthenticatedUser user, ModeledConnection connection, GuacamoleClientInformation info) throws GuacamoleException; @@ -127,7 +127,7 @@ public interface GuacamoleTunnelService { * If the connection cannot be established due to concurrent usage * rules, or if the connection group is not balancing. */ - GuacamoleTunnel getGuacamoleTunnel(AuthenticatedUser user, + GuacamoleTunnel getGuacamoleTunnel(ModeledAuthenticatedUser user, ModeledConnectionGroup connectionGroup, GuacamoleClientInformation info) throws GuacamoleException; diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/AuthenticatedUser.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledAuthenticatedUser.java similarity index 93% rename from extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/AuthenticatedUser.java rename to extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledAuthenticatedUser.java index 377606bad..7e256bb5a 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/AuthenticatedUser.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledAuthenticatedUser.java @@ -22,15 +22,18 @@ package org.apache.guacamole.auth.jdbc.user; import java.util.Collections; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; +import org.apache.guacamole.net.auth.AuthenticatedUser; import org.apache.guacamole.net.auth.AuthenticationProvider; import org.apache.guacamole.net.auth.Credentials; /** - * Associates a user with the credentials they used to authenticate. + * Associates a user with the credentials they used to authenticate, their + * corresponding ModeledUser, and the AuthenticationProvider which produced + * that ModeledUser. * * @author Michael Jumper */ -public class AuthenticatedUser extends RemoteAuthenticatedUser { +public class ModeledAuthenticatedUser extends RemoteAuthenticatedUser { /** * The ModeledUser object which is backed by the data associated with this @@ -73,7 +76,7 @@ public class AuthenticatedUser extends RemoteAuthenticatedUser { * A ModeledUser object which is backed by the data associated with * this user in the database. */ - public AuthenticatedUser(org.apache.guacamole.net.auth.AuthenticatedUser authenticatedUser, + public ModeledAuthenticatedUser(AuthenticatedUser authenticatedUser, AuthenticationProvider modelAuthenticationProvider, ModeledUser user) { super(authenticatedUser.getAuthenticationProvider(), authenticatedUser.getCredentials()); this.modelAuthenticationProvider = modelAuthenticationProvider; @@ -95,7 +98,7 @@ public class AuthenticatedUser extends RemoteAuthenticatedUser { * @param credentials * The credentials given by the user when they authenticated. */ - public AuthenticatedUser(AuthenticationProvider authenticationProvider, + public ModeledAuthenticatedUser(AuthenticationProvider authenticationProvider, ModeledUser user, Credentials credentials) { super(authenticationProvider, credentials); this.modelAuthenticationProvider = authenticationProvider; diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserContext.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserContext.java index a6a1f76e6..b70cdecfa 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserContext.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserContext.java @@ -101,7 +101,7 @@ public class UserContext extends RestrictedObject private Provider connectionRecordSetProvider; @Override - public void init(AuthenticatedUser currentUser) { + public void init(ModeledAuthenticatedUser currentUser) { super.init(currentUser); diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java index 3727f39fe..57a022e3b 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/UserService.java @@ -37,6 +37,7 @@ import org.apache.guacamole.auth.jdbc.permission.UserPermissionMapper; import org.apache.guacamole.auth.jdbc.security.PasswordEncryptionService; import org.apache.guacamole.form.Field; import org.apache.guacamole.form.PasswordField; +import org.apache.guacamole.net.auth.AuthenticatedUser; import org.apache.guacamole.net.auth.AuthenticationProvider; import org.apache.guacamole.net.auth.User; import org.apache.guacamole.net.auth.credentials.CredentialsInfo; @@ -140,7 +141,7 @@ public class UserService extends ModeledDirectoryObjectService - getImplicitPermissions(AuthenticatedUser user, UserModel model) { + getImplicitPermissions(ModeledAuthenticatedUser user, UserModel model) { // Get original set of implicit permissions Collection implicitPermissions = super.getImplicitPermissions(user, model); @@ -247,7 +248,7 @@ public class UserService extends ModeledDirectoryObjectService