From 545c525361c382d9dcba84f1336205f5062ae684 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Thu, 9 Aug 2012 14:09:52 -0700 Subject: [PATCH] Make method parameters final where it makes sense. --- .../net/sourceforge/guacamole/net/auth/Credentials.java | 8 ++++---- .../guacamole/net/event/AuthenticationFailureEvent.java | 2 +- .../guacamole/net/event/AuthenticationSuccessEvent.java | 2 +- .../sourceforge/guacamole/net/event/TunnelCloseEvent.java | 4 +++- .../guacamole/net/event/TunnelConnectEvent.java | 4 +++- 5 files changed, 12 insertions(+), 8 deletions(-) diff --git a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/auth/Credentials.java b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/auth/Credentials.java index 60d5101c0..60fc63d36 100644 --- a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/auth/Credentials.java +++ b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/auth/Credentials.java @@ -88,7 +88,7 @@ public class Credentials implements Serializable { * @param password The password to associate with this username/password * pair. */ - public void setPassword(String password) { + public void setPassword(final String password) { this.password = password; } @@ -106,7 +106,7 @@ public class Credentials implements Serializable { * @param username The username to associate with this username/password * pair. */ - public void setUsername(String username) { + public void setUsername(final String username) { this.username = username; } @@ -124,7 +124,7 @@ public class Credentials implements Serializable { * @param request The HttpServletRequest to associated with this set of * credentials. */ - public void setRequest(HttpServletRequest request) { + public void setRequest(final HttpServletRequest request) { this.request = request; } @@ -142,7 +142,7 @@ public class Credentials implements Serializable { * @param session The HttpSession to associated with this set of * credentials. */ - public void setSession(HttpSession session) { + public void setSession(final HttpSession session) { this.session = session; } diff --git a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationFailureEvent.java b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationFailureEvent.java index c42460e37..b68910045 100644 --- a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationFailureEvent.java +++ b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationFailureEvent.java @@ -22,7 +22,7 @@ public class AuthenticationFailureEvent implements CredentialEvent { * * @param credentials The credentials which failed authentication. */ - public AuthenticationFailureEvent(Credentials credentials) { + public AuthenticationFailureEvent(final Credentials credentials) { this.credentials = credentials; } diff --git a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationSuccessEvent.java b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationSuccessEvent.java index 5b6b1189b..3bb0ded56 100644 --- a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationSuccessEvent.java +++ b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/AuthenticationSuccessEvent.java @@ -22,7 +22,7 @@ public class AuthenticationSuccessEvent implements CredentialEvent { * * @param credentials The credentials which passed authentication. */ - public AuthenticationSuccessEvent(Credentials credentials) { + public AuthenticationSuccessEvent(final Credentials credentials) { this.credentials = credentials; } diff --git a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelCloseEvent.java b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelCloseEvent.java index d89715514..21ea6c0c0 100644 --- a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelCloseEvent.java +++ b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelCloseEvent.java @@ -32,7 +32,9 @@ public class TunnelCloseEvent implements CredentialEvent, TunnelEvent { * closing the tunnel. * @param tunnel The tunnel being closed. */ - public TunnelCloseEvent(Credentials credentials, GuacamoleTunnel tunnel) { + public TunnelCloseEvent(final Credentials credentials, + final GuacamoleTunnel tunnel) { + this.credentials = credentials; this.tunnel = tunnel; } diff --git a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelConnectEvent.java b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelConnectEvent.java index b1608111e..7565ca808 100644 --- a/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelConnectEvent.java +++ b/guacamole-ext/src/main/java/net/sourceforge/guacamole/net/event/TunnelConnectEvent.java @@ -32,7 +32,9 @@ public class TunnelConnectEvent implements CredentialEvent, TunnelEvent { * connecting the tunnel. * @param tunnel The tunnel being connected. */ - public TunnelConnectEvent(Credentials credentials, GuacamoleTunnel tunnel) { + public TunnelConnectEvent(final Credentials credentials, + final GuacamoleTunnel tunnel) { + this.credentials = credentials; this.tunnel = tunnel; }