From 62863f8a0b246191adda19ea2fa3ad2cae188390 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Fri, 21 Jan 2022 15:23:41 -0800 Subject: [PATCH] GUACAMOLE-641: Log possible ambiguous record retrievals at debug level. --- .../apache/guacamole/vault/ksm/secret/KsmClient.java | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java b/extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java index a72a2fdaa..3969e18c6 100644 --- a/extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java +++ b/extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java @@ -387,8 +387,12 @@ public class KsmClient { cacheLock.readLock().lock(); try { - if (cachedAmbiguousHosts.contains(hostname)) + if (cachedAmbiguousHosts.contains(hostname)) { + logger.debug("The hostname/address \"{}\" is referenced by " + + "multiple Keeper records and cannot be used to " + + "locate individual secrets.", hostname); return null; + } return cachedRecordsByHost.get(hostname); @@ -417,8 +421,12 @@ public class KsmClient { cacheLock.readLock().lock(); try { - if (cachedAmbiguousUsernames.contains(username)) + if (cachedAmbiguousUsernames.contains(username)) { + logger.debug("The username \"{}\" is referenced by multiple " + + "Keeper records and cannot be used to locate " + + "individual secrets.", username); return null; + } return cachedRecordsByUsername.get(username);