safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-1721: Store only auth token from auth response in localStorage.

Browse Source
This commit is contained in:
James Muehlner
2022-11-29 19:22:11 +00:00
parent c1b6ce4d8d
commit 69334b05e2
1 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
guacamole/src/main/frontend/src/app/auth/service/authenticationService.js
View File

@@ -61,18 +61,21 @@ angular.module('auth').factory('authenticationService', ['$injector',
var cachedResult = null; var cachedResult = null;
/** /**
* The unique identifier of the local storage key which stores the result * The unique identifier of the local storage key which stores the latest
* of the last authentication attempt. * authentication token.
* *
* @type String * @type String
*/ */
var AUTH_STORAGE_KEY = 'GUAC_AUTH'; var AUTH_TOKEN_STORAGE_KEY = 'GUAC_AUTH_TOKEN';
/** /**
* Retrieves the last successful authentication result. If the user has not * Retrieves the authentication result cached in memory. If the user has not
* yet authenticated, the user has logged out, or the last authentication * yet authenticated, the user has logged out, or the last authentication
* attempt failed, null is returned. * attempt failed, null is returned.
* *
* NOTE: setAuthenticationResult() will be called upon page load, so the
* cache should always be populated after the page has successfully loaded.
*
* @returns {AuthenticationResult} * @returns {AuthenticationResult}
* The last successful authentication result, or null if the user is not * The last successful authentication result, or null if the user is not
* currently authenticated. * currently authenticated.
@@ -84,13 +87,8 @@ angular.module('auth').factory('authenticationService', ['$injector',
return cachedResult; return cachedResult;
// Return explicit null if no auth data is currently stored // Return explicit null if no auth data is currently stored
var data = localStorageService.getItem(AUTH_STORAGE_KEY);
if (!data)
return null; return null;
// Update cache and return retrieved auth result
return (cachedResult = new AuthenticationResult(data));
}; };
/** /**
@@ -103,21 +101,28 @@ angular.module('auth').factory('authenticationService', ['$injector',
*/ */
var setAuthenticationResult = function setAuthenticationResult(data) { var setAuthenticationResult = function setAuthenticationResult(data) {
// Clear the currently-stored result if the last attempt failed // Clear the currently-stored result and auth token if the last
// attempt failed
if (!data) { if (!data) {
cachedResult = null; cachedResult = null;
localStorageService.removeItem(AUTH_STORAGE_KEY); localStorageService.removeItem(AUTH_TOKEN_STORAGE_KEY);
} }
// Otherwise store the authentication attempt directly // Otherwise, store the authentication attempt directly.
// Note that only the auth token is stored in persistent local storage.
// To re-obtain an autentication result upon a fresh page load,
// reauthenticate with the persistent token, which can be obtained by
// calling getCurrentToken().
else { else {
// Always store in cache // Always store in cache
cachedResult = data; cachedResult = data;
// Persist result past tab/window closure ONLY if not anonymous // Persist only the auth token past tab/window closure, and only
// if not anonymous
if (data.username !== AuthenticationResult.ANONYMOUS_USERNAME) if (data.username !== AuthenticationResult.ANONYMOUS_USERNAME)
localStorageService.setItem(AUTH_STORAGE_KEY, data); localStorageService.setItem(
AUTH_TOKEN_STORAGE_KEY, data.authToken);
} }
@@ -363,13 +368,13 @@ angular.module('auth').factory('authenticationService', ['$injector',
*/ */
service.getCurrentToken = function getCurrentToken() { service.getCurrentToken = function getCurrentToken() {
// Return auth token, if available // Return cached auth token, if available
var authData = getAuthenticationResult(); var authData = getAuthenticationResult();
if (authData) if (authData)
return authData.authToken; return authData.authToken;
// No auth data present // Fall back to the value from local storage if not found in cache
return null; return localStorageService.getItem(AUTH_TOKEN_STORAGE_KEY);
}; };