From 6a1b55a32708505c146b14a07010d897504ff1ca Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Mon, 18 Jun 2018 19:15:20 -0400 Subject: [PATCH] GUACAMOLE-360: deleteObject method should follow documented behavior. --- .../auth/jdbc/activeconnection/ActiveConnectionService.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java index b82adb888..1d3344db9 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/activeconnection/ActiveConnectionService.java @@ -115,8 +115,10 @@ public class ActiveConnectionService // Close connection, if it exists and we have permission ActiveConnection activeConnection = retrieveObject(user, identifier); - if (activeConnection != null - && hasObjectPermissions(user, identifier, ObjectPermission.Type.DELETE)) { + if (activeConnection == null) + return; + + if (hasObjectPermissions(user, identifier, ObjectPermission.Type.DELETE)) { // Close connection if not already closed GuacamoleTunnel tunnel = activeConnection.getTunnel();