safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-839: Allow testing of null nonce values.

Browse Source
This commit is contained in:
Michael Jumper
2023-01-26 11:35:44 -08:00
parent 2e8cf82234
commit 6bf0b8cf63
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/java/org/apache/guacamole/auth/sso/NonceService.java
View File

@@ -120,13 +120,18 @@ public class NonceService {
* invalidates that nonce. * invalidates that nonce.
* *
* @param nonce * @param nonce
* The nonce value to test. Comparisons are case-insensitive. * The nonce value to test. This value may be null, which will be
* considered an invalid nonce. Comparisons are case-insensitive.
* *
* @return * @return
* true if the provided nonce is valid, false otherwise. * true if the provided nonce is valid, false otherwise.
*/ */
public boolean isValid(String nonce) { public boolean isValid(String nonce) {
// All null nonces are invalid.
if (nonce == null)
return false;
// Remove nonce, verifying whether it was present at all // Remove nonce, verifying whether it was present at all
Long expires = nonces.remove(nonce.toLowerCase(Locale.US)); Long expires = nonces.remove(nonce.toLowerCase(Locale.US));
if (expires == null) if (expires == null)