safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-07 05:31:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

In admin screen, limit groups to organizational groups or balancing groups we have admin privileges for, and limit connections to those we have admin/update for.

Browse Source
This commit is contained in:
Michael Jumper
2013-08-16 16:52:54 -07:00
parent 7334e76679
commit 787dde88a9
1 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
guacamole/src/main/webapp/scripts/admin-ui.js
View File

@@ -1223,7 +1223,19 @@ GuacAdmin.ConnectionGroupSelect = function(group) {
var group_outside = GuacUI.createChildElement(container, "div", "overlay"); var group_outside = GuacUI.createChildElement(container, "div", "overlay");
var group_section = GuacUI.createChildElement(container, "div", "dropdown"); var group_section = GuacUI.createChildElement(container, "div", "dropdown");
var view = new GuacUI.GroupView(group, GuacUI.GroupView.SHOW_ROOT_GROUP); var view = new GuacUI.GroupView(group, GuacUI.GroupView.SHOW_ROOT_GROUP,
// Only show organizational groups or balancing groups we can administer
function(group) {
if (group.type === GuacamoleService.ConnectionGroup.Type.ORGANIZATIONAL)
return true;
return GuacAdmin.cached_permissions.administer
|| GuacAdmin.cached_permissions.administer_connection_group[group.id];
});
group_section.appendChild(view.getElement()); group_section.appendChild(view.getElement());
// Hide when clicked outside // Hide when clicked outside
@@ -1409,7 +1421,27 @@ GuacAdmin.reset = function() {
// Add new group view // Add new group view
GuacAdmin.containers.connection_list.innerHTML = ""; GuacAdmin.containers.connection_list.innerHTML = "";
var group_view = new GuacUI.GroupView(GuacAdmin.cached_root_group, GuacUI.GroupView.SHOW_CONNECTIONS); var group_view = new GuacUI.GroupView(GuacAdmin.cached_root_group, GuacUI.GroupView.SHOW_CONNECTIONS,
// Show all organizational groups and balancing groups we have admin
// for
function(group) {
if (group.type === GuacamoleService.ConnectionGroup.Type.ORGANIZATIONAL)
return true;
return GuacAdmin.cached_permissions.administer
|| GuacAdmin.cached_permissions.administer_connection_group[group.id];
},
// Only show connections we can update/administer
function(connection) {
return GuacAdmin.cached_permissions.administer
|| GuacAdmin.cached_permissions.update_connection[connection.id]
|| GuacAdmin.cached_permissions.administer_connection[connection.id];
});
GuacAdmin.containers.connection_list.appendChild(group_view.getElement()); GuacAdmin.containers.connection_list.appendChild(group_view.getElement());
// Show connection editor when connections are clicked // Show connection editor when connections are clicked
@@ -1420,8 +1452,17 @@ GuacAdmin.reset = function() {
// Show group editor when groups are clicked // Show group editor when groups are clicked
group_view.ongroupclick = function(group) { group_view.ongroupclick = function(group) {
var group_dialog = new GuacAdmin.ConnectionGroupEditor(group, parameters);
document.body.appendChild(group_dialog.getElement()); // Only show group editor if we can actually update/admin this group
if (GuacAdmin.cached_permissions.administer
|| GuacAdmin.cached_permissions.update_connection_group[group.id]
|| GuacAdmin.cached_permissions.administer_connection_group[group.id]) {
var group_dialog = new GuacAdmin.ConnectionGroupEditor(group, parameters);
document.body.appendChild(group_dialog.getElement());
}
}; };
}; };