safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-07 13:41:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUAC-1176: Clear passwords if credentials are rejected for any reason (even client error). Flag generic login error only for specifically invalid credentials.

Browse Source
This commit is contained in:
Michael Jumper
2015-06-03 00:35:10 -07:00
parent 7a3503a40e
commit 85dae9e52a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
guacamole/src/main/webapp/app/login/directives/login.js
View File

@@ -123,9 +123,12 @@ angular.module('login').directive('guacLogin', [function guacLogin() {
// Reset upon failure // Reset upon failure
['catch'](function loginFailed(error) { ['catch'](function loginFailed(error) {
// Clear out passwords and flag error if credentials are invalid // Flag generic error for invalid login
if (error.type === Error.Type.INVALID_CREDENTIALS) { if (error.type === Error.Type.INVALID_CREDENTIALS)
$scope.loginError = true; $scope.loginError = true;
// Clear out passwords if the credentials were rejected for any reason
if (error.type !== Error.Type.INSUFFICIENT_CREDENTIALS) {
angular.forEach($scope.form, function clearEnteredValueIfPassword(field) { angular.forEach($scope.form, function clearEnteredValueIfPassword(field) {
// Remove entered value only if field is a password field // Remove entered value only if field is a password field