safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use final Strings for attribute names.

Browse Source
This commit is contained in:
Michael Jumper
2012-03-23 15:10:55 -07:00
parent 2cf91df11e
commit 8a27a79a6b
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
guacamole/src/main/java/net/sourceforge/guacamole/net/basic/AuthenticatingHttpServlet.java
View File

@@ -43,6 +43,16 @@ public abstract class AuthenticatingHttpServlet extends HttpServlet {
private Logger logger = LoggerFactory.getLogger(AuthenticatingHttpServlet.class); private Logger logger = LoggerFactory.getLogger(AuthenticatingHttpServlet.class);
/**
* The session attribute holding the map of configurations.
*/
private static final String CONFIGURATIONS_ATTRIBUTE = "GUAC_CONFIGS";
/**
* The session attribute holding the credentials authorizing this session.
*/
private static final String CREDENTIALS_ATTRIBUTE = "GUAC_CREDS";
/** /**
* The error message to be provided to the client user if authentication * The error message to be provided to the client user if authentication
* fails for ANY REASON. * fails for ANY REASON.
@@ -151,7 +161,7 @@ public abstract class AuthenticatingHttpServlet extends HttpServlet {
* @return The credentials associated with the given session. * @return The credentials associated with the given session.
*/ */
protected Credentials getCredentials(HttpSession session) { protected Credentials getCredentials(HttpSession session) {
return (Credentials) session.getAttribute("GUAC_CREDS"); return (Credentials) session.getAttribute(CREDENTIALS_ATTRIBUTE);
} }
/** /**
@@ -161,7 +171,7 @@ public abstract class AuthenticatingHttpServlet extends HttpServlet {
* @return The configurations associated with the given session. * @return The configurations associated with the given session.
*/ */
protected Map<String, GuacamoleConfiguration> getConfigurations(HttpSession session) { protected Map<String, GuacamoleConfiguration> getConfigurations(HttpSession session) {
return (Map<String, GuacamoleConfiguration>) session.getAttribute("GUAC_CONFIGS"); return (Map<String, GuacamoleConfiguration>) session.getAttribute(CONFIGURATIONS_ATTRIBUTE);
} }
@Override @Override
@@ -253,8 +263,8 @@ public abstract class AuthenticatingHttpServlet extends HttpServlet {
} }
// Associate configs and credentials with session // Associate configs and credentials with session
httpSession.setAttribute("GUAC_CONFIGS", configs); httpSession.setAttribute(CONFIGURATIONS_ATTRIBUTE, configs);
httpSession.setAttribute("GUAC_CREDS", credentials); httpSession.setAttribute(CREDENTIALS_ATTRIBUTE, credentials);
} }