safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-926: Ensure that the directory patch replace operation writes to the same directory it reads from.

Browse Source
This commit is contained in:
James Muehlner
2023-04-22 00:32:19 +00:00
parent 9e54b58af3
commit 8c19e6ca81
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java
View File

@@ -430,6 +430,10 @@ public abstract class DirectoryResource<InternalType extends Identifiable, Exter
* @param identifier
* The identifier of the object to retrieve from the directory.
*
* @param directory
* The directory to fetch the object from. If null, the directory
* associated with this DirectoryResource instance will be used.
*
* @return
* The object from the directory with the provided identifier.
*
@@ -439,9 +443,15 @@ public abstract class DirectoryResource<InternalType extends Identifiable, Exter
* the object.
*/
@Nonnull
private InternalType getObjectByIdentifier(String identifier)
private InternalType getObjectByIdentifier(
String identifier, @Nullable Directory<InternalType> directory)
throws GuacamoleException {
// Use the directory associated with this instance if not otherwise
// specified
if (directory == null)
directory = this.directory;
// Retrieve the object having the given identifier
InternalType object;
try {
@@ -639,10 +649,11 @@ public abstract class DirectoryResource<InternalType extends Identifiable, Exter
try {
// Fetch the object to be updated. If no object is
// found, a directory GET failure event will be
// logged, and the update attempt will be aborted.
original = getObjectByIdentifier(identifier);
// Fetch the object to be updated from the atomic
// directory instance. If no object is found, a
// directory GET failure event will be logged, and
// the update attempt will be aborted.
original = getObjectByIdentifier(identifier, directory);
// Apply the changes to the original object
translator.applyExternalChanges(
@@ -849,7 +860,7 @@ public abstract class DirectoryResource<InternalType extends Identifiable, Exter
// Fetch the object to be updated. If no object is found, a directory
// GET failure event will be logged. If no exception is thrown, the
// object is guaranteed to exist
InternalType object = getObjectByIdentifier(identifier);
InternalType object = getObjectByIdentifier(identifier, null);
// Return a resource which provides access to the retrieved object
DirectoryObjectResource<InternalType, ExternalType> resource = resourceFactory.create(authenticatedUser, userContext, directory, object);