From 955d5fb11f861f0476741a950cbb064150ae9bd4 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Mon, 5 Jun 2017 22:37:49 -0400 Subject: [PATCH] GUACAMOLE-102: Clarification for comments on weights less than 1. --- .../guacamole/auth/jdbc/connection/ConnectionModel.java | 4 ++-- .../auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionModel.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionModel.java index 4d2810195..92ee91d91 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionModel.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionModel.java @@ -175,8 +175,8 @@ public class ConnectionModel extends ChildObjectModel { * Sets the connection weight. * * @param connectionWeight - * The weight of the connection. null is acceptable, negative values - * indicate that the connection should not be used. + * The weight of the connection. null is acceptable, and anything + * less than one will prevent the connection from being used. */ public void setConnectionWeight(Integer connectionWeight) { this.connectionWeight = connectionWeight; diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java index 6480ec752..c9999abe4 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java @@ -216,7 +216,7 @@ public class RestrictedGuacamoleTunnelService // Return the first unreserved connection for (ModeledConnection connection : sortedConnections) { - // If connection weight is zero or negative, this host is disabled and should not be used. + // If connection weight is less than 1 this host is disabled and should not be used. if (connection.getConnectionWeight() < 1) { logger.debug("Weight for {} is < 1, connection will be skipped.", connection.getName()); continue;