GUAC-1161: Reorganize authenticationInterceptor to match service pattern used elsewhere.

guacamole/src/main/webapp/app/index/services/authenticationInterceptor.js

@@ -20,13 +20,29 @@
  * THE SOFTWARE.
  */
 
-angular.module('index').factory('authenticationInterceptor', ['$location', '$q', 
-        function authenticationInterceptor($location, $q) {
+angular.module('index').factory('authenticationInterceptor', ['$injector',
+        function authenticationInterceptor($injector) {
 
-    return {
+    // Required services
+    var $location = $injector.get('$location');
+    var $q        = $injector.get('$q');
 
-        // Redirect users to login if authorization fails
-        responseError: function handleErrorResponse(rejection) {
+    var service = {};
+
+    /**
+     * Redirect users to login if authorization fails. This is called
+     * automatically when this service is registered as an interceptor, as
+     * documented at:
+     * 
+     * https://docs.angularjs.org/api/ng/service/$http#interceptors
+     *
+     * @param {HttpPromise} rejection
+     *     The promise associated with the HTTP request that failed.
+     *
+     * @returns {Promise}
+     *     A rejected promise containing the originally-rejected HttpPromise.
+     */
+    service.responseError = function responseError(rejection) {
 
         // Only redirect failed authentication requests
         if ((rejection.status === 401 || rejection.status === 403)
@@ -40,8 +56,8 @@ angular.module('index').factory('authenticationInterceptor', ['$location', '$q',
 
         return $q.reject(rejection);
 
-        }
-
     };
 
+    return service;
+
 }]);