GUACAMOLE-352: Additionally click() while attempting to refocus the input sink field. Do not rely on autofocus, which may result in the field being partly focused (outlined as focused) but not receiving any actual text input.

This commit is contained in:
Michael Jumper
2017-12-18 14:56:39 -08:00
parent e5e01beb60
commit 9f6b2fad37

View File

@@ -1440,8 +1440,8 @@ Guacamole.Keyboard.InputSink = function InputSink() {
* @type {Element}
*/
var field = document.createElement('textarea');
field.setAttribute('autofocus', 'autofocus');
field.style.position = 'fixed';
field.style.outline = 'none';
field.style.border = 'none';
field.style.width = '10px';
field.style.height = '10px';
@@ -1463,6 +1463,16 @@ Guacamole.Keyboard.InputSink = function InputSink() {
// Keep internal field contents clear
field.addEventListener("change", clear, false);
// Whenever focus is gained, automatically click to ensure cursor is
// actually placed within the field (the field may simply be highlighted or
// outlined otherwise)
field.addEventListener("focus", function focusReceived() {
window.setTimeout(function deferRefocus() {
field.click();
field.select();
}, 0);
}, true);
/**
* Attempts to focus the underlying input field. The focus attempt occurs
* asynchronously, and may silently fail depending on browser restrictions.
@@ -1470,7 +1480,6 @@ Guacamole.Keyboard.InputSink = function InputSink() {
this.focus = function focus() {
window.setTimeout(function deferRefocus() {
field.focus(); // Focus must be deferred to work reliably across browsers
field.select();
}, 0);
};