From a2efb47e3cdd7c7380818f775a01c5f4ef829f72 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Thu, 13 Aug 2015 12:51:15 -0700 Subject: [PATCH] GUAC-1293: Rename click handler sensibly. No need to prevent default, etc. for clicks. --- .../main/webapp/app/client/directives/guacFileBrowser.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/guacamole/src/main/webapp/app/client/directives/guacFileBrowser.js b/guacamole/src/main/webapp/app/client/directives/guacFileBrowser.js index f5a8c684d..26be23b48 100644 --- a/guacamole/src/main/webapp/app/client/directives/guacFileBrowser.js +++ b/guacamole/src/main/webapp/app/client/directives/guacFileBrowser.js @@ -162,7 +162,7 @@ angular.module('client').directive('guacFileBrowser', [function guacFileBrowser( } // Mark file as focused upon click - element.on('click', function focusFile(e) { + element.on('click', function handleFileClick() { // Fire file-specific action if already focused if (element.hasClass('focused')) { @@ -176,10 +176,6 @@ angular.module('client').directive('guacFileBrowser', [function guacFileBrowser( element.addClass('focused'); } - // Do not allow default action - e.preventDefault(); - e.stopPropagation(); - }); // Prevent text selection during navigation