safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-38: Clean up minor code issues.

Browse Source
This commit is contained in:
Nick Couchman
2018-05-14 14:00:50 -04:00
parent 27f4ad01f5
commit aaada49dfe
5 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java
View File

@@ -50,7 +50,7 @@ public class QuickConnectDirectory extends SimpleDirectory<Connection> {
/** /**
* The internal counter for connection IDs. * The internal counter for connection IDs.
*/ */
private AtomicInteger connectionId; private final AtomicInteger connectionId;
/** /**
* Creates a new QuickConnectDirectory with the default * Creates a new QuickConnectDirectory with the default

2
extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectUserContext.java
View File

@@ -25,9 +25,7 @@ import org.apache.guacamole.GuacamoleException;
import org.apache.guacamole.net.auth.AbstractUserContext; import org.apache.guacamole.net.auth.AbstractUserContext;
import org.apache.guacamole.net.auth.AuthenticationProvider; import org.apache.guacamole.net.auth.AuthenticationProvider;
import org.apache.guacamole.net.auth.ConnectionGroup; import org.apache.guacamole.net.auth.ConnectionGroup;
import org.apache.guacamole.net.auth.Directory;
import org.apache.guacamole.net.auth.User; import org.apache.guacamole.net.auth.User;
import org.apache.guacamole.net.auth.simple.SimpleDirectory;
import org.apache.guacamole.net.auth.simple.SimpleUser; import org.apache.guacamole.net.auth.simple.SimpleUser;
/** /**

2
extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectionGroup.java
View File

@@ -39,7 +39,7 @@ public class QuickConnectionGroup extends AbstractConnectionGroup {
/** /**
* A set that will store the Connection identifiers for this group. * A set that will store the Connection identifiers for this group.
*/ */
private Set<String> connectionIdentifiers = private final Set<String> connectionIdentifiers =
new HashSet<String>(Collections.<String>emptyList()); new HashSet<String>(Collections.<String>emptyList());
/** /**

2
extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/rest/QuickConnectREST.java
View File

@@ -38,7 +38,7 @@ public class QuickConnectREST {
/** /**
* The connection directory for this REST endpoint. * The connection directory for this REST endpoint.
*/ */
private QuickConnectDirectory directory; private final QuickConnectDirectory directory;
/** /**
* Construct a new QuickConnectREST class, taking in a * Construct a new QuickConnectREST class, taking in a

10
extensions/guacamole-auth-quickconnect/src/test/java/org/apache/guacamole/auth/quickconnect/utility/QCParserTest.java
View File

@@ -20,7 +20,6 @@
package org.apache.guacamole.auth.quickconnect.utility; package org.apache.guacamole.auth.quickconnect.utility;
import java.io.UnsupportedEncodingException; import java.io.UnsupportedEncodingException;
import java.util.HashMap;
import java.util.Map; import java.util.Map;
import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleException;
import org.apache.guacamole.protocol.GuacamoleConfiguration; import org.apache.guacamole.protocol.GuacamoleConfiguration;
@@ -35,6 +34,9 @@ public class QCParserTest {
/** /**
* Verify that the parseQueryString() method functions as designed. * Verify that the parseQueryString() method functions as designed.
*
* @throws UnsupportedEncodingException
* If Java lacks UTF-8 support.
*/ */
@Test @Test
public void testParseQueryString() throws UnsupportedEncodingException { public void testParseQueryString() throws UnsupportedEncodingException {
@@ -51,6 +53,9 @@ public class QCParserTest {
/** /**
* Verify that the parseUserInfo() method functions as designed. * Verify that the parseUserInfo() method functions as designed.
*
* @throws UnsupportedEncodingException
* If Java lacks UTF-8 support.
*/ */
@Test @Test
public void testParseUserInfo() throws UnsupportedEncodingException { public void testParseUserInfo() throws UnsupportedEncodingException {
@@ -79,6 +84,9 @@ public class QCParserTest {
/** /**
* Verify that the getConfiguration() method returns the expected * Verify that the getConfiguration() method returns the expected
* GuacamoleConfiguration object. * GuacamoleConfiguration object.
*
* @throws GuacamoleException
* If the configuration cannot be parsed from the given URI.
*/ */
@Test @Test
public void testGetConfiguration() throws GuacamoleException { public void testGetConfiguration() throws GuacamoleException {