GUACAMOLE-195: Fix comments to correctly specify that this is HTTP header-based authentication.

This commit is contained in:
Nick Couchman
2017-01-31 22:37:39 -05:00
parent 63cb838df1
commit b8fb8f771b
5 changed files with 9 additions and 8 deletions

View File

@@ -38,7 +38,7 @@ import java.security.Principal;
public class AuthenticationProviderService {
/**
* Service for retrieving LDAP server configuration information.
* Service for retrieving header configuration information.
*/
@Inject
private ConfigurationService confService;
@@ -67,7 +67,7 @@ public class AuthenticationProviderService {
public AuthenticatedUser authenticateUser(Credentials credentials)
throws GuacamoleException {
// Pull HTTP ticket from request if present
// Pull HTTP header from request if present
HttpServletRequest request = credentials.getRequest();
if (request != null) {
String username = request.getRemoteUser();

View File

@@ -24,7 +24,8 @@ import org.apache.guacamole.GuacamoleException;
import org.apache.guacamole.environment.Environment;
/**
* Service for retrieving configuration information regarding the LDAP server.
* Service for retrieving configuration information for HTTP header-based
* authentication.
*
* @author Nick Couchman
*/

View File

@@ -29,7 +29,7 @@ import org.apache.guacamole.net.auth.UserContext;
/**
* Guacamole authentication backend which authenticates users using an
* arbitrary external system implementing HTTP. No storage for connections is
* arbitrary external HTTP header. No storage for connections is
* provided - only authentication. Storage must be provided by some other
* extension.
*
@@ -45,7 +45,7 @@ public class HTTPAuthenticationProvider implements AuthenticationProvider {
/**
* Creates a new HTTPAuthenticationProvider that authenticates users
* against an HTTP service
* using HTTP headers.
*
* @throws GuacamoleException
* If a required property is missing, or an error occurs while parsing
@@ -69,7 +69,7 @@ public class HTTPAuthenticationProvider implements AuthenticationProvider {
public AuthenticatedUser authenticateUser(Credentials credentials)
throws GuacamoleException {
// Attempt to authenticate user with given credentials
// Pass credentials to authentication service.
AuthenticationProviderService authProviderService = injector.getInstance(AuthenticationProviderService.class);
return authProviderService.authenticateUser(credentials);

View File

@@ -25,7 +25,7 @@ import org.apache.guacamole.net.auth.AuthenticationProvider;
import org.apache.guacamole.net.auth.Credentials;
/**
* An HTTP-specific implementation of AuthenticatedUser, associating a
* An HTTP header implementation of AuthenticatedUser, associating a
* username and particular set of credentials with the HTTP authentication
* provider.
*

View File

@@ -2,7 +2,7 @@
"guacamoleVersion" : "0.9.11-incubating",
"name" : "HTTP Authentication Extension",
"name" : "HTTP Header Authentication Extension",
"namespace" : "guac-http",
"authProviders" : [