safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-195: Fix comments to correctly specify that this is HTTP header-based authentication.

Browse Source
This commit is contained in:
Nick Couchman
2017-01-31 22:37:39 -05:00
parent 63cb838df1
commit b8fb8f771b
5 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/guacamole-auth-http/src/main/java/org/apache/guacamole/auth/http/AuthenticationProviderService.java
View File

@@ -38,7 +38,7 @@ import java.security.Principal;
public class AuthenticationProviderService { public class AuthenticationProviderService {
/** /**
* Service for retrieving LDAP server configuration information. * Service for retrieving header configuration information.
*/ */
@Inject @Inject
private ConfigurationService confService; private ConfigurationService confService;
@@ -67,7 +67,7 @@ public class AuthenticationProviderService {
public AuthenticatedUser authenticateUser(Credentials credentials) public AuthenticatedUser authenticateUser(Credentials credentials)
throws GuacamoleException { throws GuacamoleException {
// Pull HTTP ticket from request if present // Pull HTTP header from request if present
HttpServletRequest request = credentials.getRequest(); HttpServletRequest request = credentials.getRequest();
if (request != null) { if (request != null) {
String username = request.getRemoteUser(); String username = request.getRemoteUser();

3
extensions/guacamole-auth-http/src/main/java/org/apache/guacamole/auth/http/ConfigurationService.java
View File

@@ -24,7 +24,8 @@ import org.apache.guacamole.GuacamoleException;
import org.apache.guacamole.environment.Environment; import org.apache.guacamole.environment.Environment;
/** /**
* Service for retrieving configuration information regarding the LDAP server. * Service for retrieving configuration information for HTTP header-based
* authentication.
* *
* @author Nick Couchman * @author Nick Couchman
*/ */

6
extensions/guacamole-auth-http/src/main/java/org/apache/guacamole/auth/http/HTTPAuthenticationProvider.java
View File

@@ -29,7 +29,7 @@ import org.apache.guacamole.net.auth.UserContext;
/** /**
* Guacamole authentication backend which authenticates users using an * Guacamole authentication backend which authenticates users using an
* arbitrary external system implementing HTTP. No storage for connections is * arbitrary external HTTP header. No storage for connections is
* provided - only authentication. Storage must be provided by some other * provided - only authentication. Storage must be provided by some other
* extension. * extension.
* *
@@ -45,7 +45,7 @@ public class HTTPAuthenticationProvider implements AuthenticationProvider {
/** /**
* Creates a new HTTPAuthenticationProvider that authenticates users * Creates a new HTTPAuthenticationProvider that authenticates users
* against an HTTP service * using HTTP headers.
* *
* @throws GuacamoleException * @throws GuacamoleException
* If a required property is missing, or an error occurs while parsing * If a required property is missing, or an error occurs while parsing
@@ -69,7 +69,7 @@ public class HTTPAuthenticationProvider implements AuthenticationProvider {
public AuthenticatedUser authenticateUser(Credentials credentials) public AuthenticatedUser authenticateUser(Credentials credentials)
throws GuacamoleException { throws GuacamoleException {
// Attempt to authenticate user with given credentials // Pass credentials to authentication service.
AuthenticationProviderService authProviderService = injector.getInstance(AuthenticationProviderService.class); AuthenticationProviderService authProviderService = injector.getInstance(AuthenticationProviderService.class);
return authProviderService.authenticateUser(credentials); return authProviderService.authenticateUser(credentials);

2
extensions/guacamole-auth-http/src/main/java/org/apache/guacamole/auth/http/user/AuthenticatedUser.java
View File

@@ -25,7 +25,7 @@ import org.apache.guacamole.net.auth.AuthenticationProvider;
import org.apache.guacamole.net.auth.Credentials; import org.apache.guacamole.net.auth.Credentials;
/** /**
* An HTTP-specific implementation of AuthenticatedUser, associating a * An HTTP header implementation of AuthenticatedUser, associating a
* username and particular set of credentials with the HTTP authentication * username and particular set of credentials with the HTTP authentication
* provider. * provider.
* *

2
extensions/guacamole-auth-http/src/main/resources/guac-manifest.json
View File

@@ -2,7 +2,7 @@
"guacamoleVersion" : "0.9.11-incubating", "guacamoleVersion" : "0.9.11-incubating",
"name" : "HTTP Authentication Extension", "name" : "HTTP Header Authentication Extension",
"namespace" : "guac-http", "namespace" : "guac-http",
"authProviders" : [ "authProviders" : [