diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCEnvironment.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCEnvironment.java index ea4bcd959..a6313a965 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCEnvironment.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCEnvironment.java @@ -166,4 +166,30 @@ public abstract class JDBCEnvironment extends DelegatingEnvironment { */ public abstract boolean autoCreateAbsentAccounts() throws GuacamoleException; + /** + * Returns the username that should be used when authenticating with the + * database containing the Guacamole authentication tables. + * + * @return + * The username for the database. + * + * @throws GuacamoleException + * If an error occurs while retrieving the property value, or if the + * value was not set, as this property is required. + */ + public abstract String getUsername() throws GuacamoleException; + + /** + * Returns the password that should be used authenticating with the + * database containing the Guacamole authentication tables. + * + * @return + * The password for the database. + * + * @throws GuacamoleException + * If an error occurs while retrieving the property value, or if the + * value was not set, as this property is required. + */ + public abstract String getPassword() throws GuacamoleException; + } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java index d1fc93d40..a4e1ef2e0 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java @@ -72,8 +72,8 @@ public class MySQLAuthenticationProviderModule implements Module { myBatisProperties.setProperty("JDBC.host", environment.getMySQLHostname()); myBatisProperties.setProperty("JDBC.port", String.valueOf(environment.getMySQLPort())); myBatisProperties.setProperty("JDBC.schema", environment.getMySQLDatabase()); - myBatisProperties.setProperty("JDBC.username", environment.getMySQLUsername()); - myBatisProperties.setProperty("JDBC.password", environment.getMySQLPassword()); + myBatisProperties.setProperty("JDBC.username", environment.getUsername()); + myBatisProperties.setProperty("JDBC.password", environment.getPassword()); myBatisProperties.setProperty("JDBC.autoCommit", "false"); myBatisProperties.setProperty("mybatis.pooled.pingEnabled", "true"); myBatisProperties.setProperty("mybatis.pooled.pingQuery", "SELECT 1"); diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java index 31f04e559..f4aa645b1 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java @@ -241,34 +241,14 @@ public class MySQLEnvironment extends JDBCEnvironment { public String getMySQLDatabase() throws GuacamoleException { return getRequiredProperty(MySQLGuacamoleProperties.MYSQL_DATABASE); } - - /** - * Returns the username that should be used when authenticating with the - * MySQL database containing the Guacamole authentication tables. - * - * @return - * The username for the MySQL database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getMySQLUsername() throws GuacamoleException { + + @Override + public String getUsername() throws GuacamoleException { return getRequiredProperty(MySQLGuacamoleProperties.MYSQL_USERNAME); } - /** - * Returns the password that should be used when authenticating with the - * MySQL database containing the Guacamole authentication tables. - * - * @return - * The password for the MySQL database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getMySQLPassword() throws GuacamoleException { + @Override + public String getPassword() throws GuacamoleException { return getRequiredProperty(MySQLGuacamoleProperties.MYSQL_PASSWORD); } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/PostgreSQLAuthenticationProviderModule.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/PostgreSQLAuthenticationProviderModule.java index 280cead71..0b285f100 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/PostgreSQLAuthenticationProviderModule.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/PostgreSQLAuthenticationProviderModule.java @@ -64,8 +64,8 @@ public class PostgreSQLAuthenticationProviderModule implements Module { myBatisProperties.setProperty("JDBC.host", environment.getPostgreSQLHostname()); myBatisProperties.setProperty("JDBC.port", String.valueOf(environment.getPostgreSQLPort())); myBatisProperties.setProperty("JDBC.schema", environment.getPostgreSQLDatabase()); - myBatisProperties.setProperty("JDBC.username", environment.getPostgreSQLUsername()); - myBatisProperties.setProperty("JDBC.password", environment.getPostgreSQLPassword()); + myBatisProperties.setProperty("JDBC.username", environment.getUsername()); + myBatisProperties.setProperty("JDBC.password", environment.getPassword()); myBatisProperties.setProperty("JDBC.autoCommit", "false"); myBatisProperties.setProperty("mybatis.pooled.pingEnabled", "true"); myBatisProperties.setProperty("mybatis.pooled.pingQuery", "SELECT 1"); diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/conf/PostgreSQLEnvironment.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/conf/PostgreSQLEnvironment.java index 012877cf6..2ead15b6e 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/conf/PostgreSQLEnvironment.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-postgresql/src/main/java/org/apache/guacamole/auth/postgresql/conf/PostgreSQLEnvironment.java @@ -232,34 +232,14 @@ public class PostgreSQLEnvironment extends JDBCEnvironment { public String getPostgreSQLDatabase() throws GuacamoleException { return getRequiredProperty(PostgreSQLGuacamoleProperties.POSTGRESQL_DATABASE); } - - /** - * Returns the username that should be used when authenticating with the - * PostgreSQL database containing the Guacamole authentication tables. - * - * @return - * The username for the PostgreSQL database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getPostgreSQLUsername() throws GuacamoleException { + + @Override + public String getUsername() throws GuacamoleException { return getRequiredProperty(PostgreSQLGuacamoleProperties.POSTGRESQL_USERNAME); } - - /** - * Returns the password that should be used when authenticating with the - * PostgreSQL database containing the Guacamole authentication tables. - * - * @return - * The password for the PostgreSQL database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getPostgreSQLPassword() throws GuacamoleException { + + @Override + public String getPassword() throws GuacamoleException { return getRequiredProperty(PostgreSQLGuacamoleProperties.POSTGRESQL_PASSWORD); } diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/SQLServerAuthenticationProviderModule.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/SQLServerAuthenticationProviderModule.java index bcd4bc94c..ead21066d 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/SQLServerAuthenticationProviderModule.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/SQLServerAuthenticationProviderModule.java @@ -69,8 +69,8 @@ public class SQLServerAuthenticationProviderModule implements Module { myBatisProperties.setProperty("JDBC.host", environment.getSQLServerHostname()); myBatisProperties.setProperty("JDBC.port", String.valueOf(environment.getSQLServerPort())); myBatisProperties.setProperty("JDBC.schema", environment.getSQLServerDatabase()); - myBatisProperties.setProperty("JDBC.username", environment.getSQLServerUsername()); - myBatisProperties.setProperty("JDBC.password", environment.getSQLServerPassword()); + myBatisProperties.setProperty("JDBC.username", environment.getUsername()); + myBatisProperties.setProperty("JDBC.password", environment.getPassword()); myBatisProperties.setProperty("JDBC.autoCommit", "false"); myBatisProperties.setProperty("mybatis.pooled.pingEnabled", "true"); diff --git a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/conf/SQLServerEnvironment.java b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/conf/SQLServerEnvironment.java index 563db0ea2..0e1554371 100644 --- a/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/conf/SQLServerEnvironment.java +++ b/extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/conf/SQLServerEnvironment.java @@ -222,33 +222,13 @@ public class SQLServerEnvironment extends JDBCEnvironment { return getRequiredProperty(SQLServerGuacamoleProperties.SQLSERVER_DATABASE); } - /** - * Returns the username that should be used when authenticating with the - * SQLServer database containing the Guacamole authentication tables. - * - * @return - * The username for the SQLServer database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getSQLServerUsername() throws GuacamoleException { + @Override + public String getUsername() throws GuacamoleException { return getRequiredProperty(SQLServerGuacamoleProperties.SQLSERVER_USERNAME); } - /** - * Returns the password that should be used when authenticating with the - * SQLServer database containing the Guacamole authentication tables. - * - * @return - * The password for the SQLServer database. - * - * @throws GuacamoleException - * If an error occurs while retrieving the property value, or if the - * value was not set, as this property is required. - */ - public String getSQLServerPassword() throws GuacamoleException { + @Override + public String getPassword() throws GuacamoleException { return getRequiredProperty(SQLServerGuacamoleProperties.SQLSERVER_PASSWORD); }