safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-10-31 09:03:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUAC-1126: Maintain session-local data through login/logout events broadcast from the authentication service.

Browse Source
This commit is contained in:
Michael Jumper
2015-04-09 13:01:37 -07:00
parent 311d56bae5
commit c69f7db522
6 changed files with 49 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
guacamole/src/main/webapp/app/auth/authModule.js
View File

@@ -23,4 +23,4 @@
/**
* The module for authentication and management of tokens.
*/
angular.module('auth', ['ngCookies', 'rest']);
angular.module('auth', ['ngCookies']);

43
guacamole/src/main/webapp/app/auth/service/authenticationService.js
View File

@@ -22,6 +22,16 @@
/**
* A service for authenticating a user against the REST API.
*
* This service broadcasts two events on $rootScope depending on the result of
* authentication operations: 'guacLogin' if authentication was successful and
* a new token was created, and 'guacLogout' if an existing token is being
* destroyed or replaced. Both events will be passed the related token as their
* sole parameter.
*
* If a login attempt results in an existing token being replaced, 'guacLogout'
* will be broadcast first for the token being replaced, followed by
* 'guacLogin' for the new token.
*/
angular.module('auth').factory('authenticationService', ['$injector',
function authenticationService($injector) {
@@ -30,7 +40,7 @@ angular.module('auth').factory('authenticationService', ['$injector',
var $cookieStore = $injector.get('$cookieStore');
var $http = $injector.get('$http');
var $q = $injector.get('$q');
var cacheService = $injector.get('cacheService');
var $rootScope = $injector.get('$rootScope');
var service = {};
@@ -102,12 +112,25 @@ angular.module('auth').factory('authenticationService', ['$injector',
var currentToken = service.getCurrentToken();
// If a new token was received, ensure the old token is invalidated
if (currentToken && data.authToken !== currentToken) {
service.logout()
['finally'](function logoutComplete() {
// If a new token was received, ensure the old token is invalidated,
// if any, and notify listeners of the new token
if (data.authToken !== currentToken) {
// If an old token existed, explicitly logout first
if (currentToken) {
service.logout()
['finally'](function logoutComplete() {
completeAuthentication(data);
$rootScope.$broadcast('guacLogin', data.authToken);
});
}
// Otherwise, simply complete authentication and notify of login
else {
completeAuthentication(data);
});
$rootScope.$broadcast('guacLogin', data.authToken);
}
}
// Otherwise, just finish the auth process
@@ -195,13 +218,13 @@ angular.module('auth').factory('authenticationService', ['$injector',
*/
service.logout = function logout() {
// Clear all caches
cacheService.clearCaches();
// Clear authentication data
var token = service.getCurrentToken();
$cookieStore.remove(AUTH_COOKIE_ID);
// Notify listeners that a token is being destroyed
$rootScope.$broadcast('guacLogout', token);
// Delete old token
return $http({
method: 'DELETE',
@@ -249,6 +272,6 @@ angular.module('auth').factory('authenticationService', ['$injector',
return null;
};
return service;
}]);