GUAC-1126: Query root group and permissions directly within user menu.

This commit is contained in:
Michael Jumper
2015-04-06 12:10:26 -07:00
parent e868be57b8
commit cff71345d1
10 changed files with 52 additions and 40 deletions

View File

@@ -59,7 +59,7 @@
<!-- Stationary header --> <!-- Stationary header -->
<div class="header"> <div class="header">
<h2>{{client.name}}</h2> <h2>{{client.name}}</h2>
<guac-user-menu permissions="permissions" root-group="rootConnectionGroup"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<!-- Scrollable body --> <!-- Scrollable body -->

View File

@@ -27,7 +27,7 @@
<!-- The recent connections for this user --> <!-- The recent connections for this user -->
<div class="header"> <div class="header">
<h2>{{'HOME.SECTION_HEADER_RECENT_CONNECTIONS' | translate}}</h2> <h2>{{'HOME.SECTION_HEADER_RECENT_CONNECTIONS' | translate}}</h2>
<guac-user-menu permissions="permissions" root-group="rootConnectionGroup"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<div class="recent-connections"> <div class="recent-connections">
<guac-recent-connections root-group="rootConnectionGroup"></guac-recent-connections> <guac-recent-connections root-group="rootConnectionGroup"></guac-recent-connections>

View File

@@ -25,7 +25,7 @@ THE SOFTWARE.
<!-- Main property editor --> <!-- Main property editor -->
<div class="header"> <div class="header">
<h2>{{'MANAGE_CONNECTION.SECTION_HEADER_EDIT_CONNECTION' | translate}}</h2> <h2>{{'MANAGE_CONNECTION.SECTION_HEADER_EDIT_CONNECTION' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<div class="section"> <div class="section">
<table class="properties"> <table class="properties">

View File

@@ -25,7 +25,7 @@ THE SOFTWARE.
<!-- Main property editor --> <!-- Main property editor -->
<div class="header"> <div class="header">
<h2>{{'MANAGE_CONNECTION_GROUP.SECTION_HEADER_EDIT_CONNECTION_GROUP' | translate}}</h2> <h2>{{'MANAGE_CONNECTION_GROUP.SECTION_HEADER_EDIT_CONNECTION_GROUP' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<div class="section"> <div class="section">
<table class="properties"> <table class="properties">

View File

@@ -24,7 +24,7 @@ THE SOFTWARE.
<div class="header"> <div class="header">
<h2>{{'MANAGE_CONNECTION.SECTION_HEADER_CONNECTIONS' | translate}}</h2> <h2>{{'MANAGE_CONNECTION.SECTION_HEADER_CONNECTIONS' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<!-- Connection management --> <!-- Connection management -->

View File

@@ -24,7 +24,7 @@ THE SOFTWARE.
<div class="header"> <div class="header">
<h2>{{'MANAGE_SESSION.SECTION_HEADER_SESSIONS' | translate}}</h2> <h2>{{'MANAGE_SESSION.SECTION_HEADER_SESSIONS' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<!-- User Session management --> <!-- User Session management -->

View File

@@ -25,7 +25,7 @@ THE SOFTWARE.
<!-- Main property editor --> <!-- Main property editor -->
<div class="header"> <div class="header">
<h2>{{'MANAGE_USER.SECTION_HEADER_EDIT_USER' | translate}}</h2> <h2>{{'MANAGE_USER.SECTION_HEADER_EDIT_USER' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<div class="section"> <div class="section">
<table class="properties"> <table class="properties">

View File

@@ -24,7 +24,7 @@ THE SOFTWARE.
<div class="header"> <div class="header">
<h2>{{'MANAGE_USER.SECTION_HEADER_USERS' | translate}}</h2> <h2>{{'MANAGE_USER.SECTION_HEADER_USERS' | translate}}</h2>
<guac-user-menu permissions="permissions"></guac-user-menu> <guac-user-menu></guac-user-menu>
</div> </div>
<!-- User management --> <!-- User management -->

View File

@@ -30,22 +30,6 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
restrict: 'E', restrict: 'E',
replace: true, replace: true,
scope: { scope: {
/**
* The permissions associated with the user for whom this menu is
* being displayed.
*
* @type PermissionSet
*/
permissions : '=',
/**
* The root of the connection group tree.
*
* @type ConnectionGroup
*/
rootGroup : '='
}, },
templateUrl: 'app/navigation/templates/guacUserMenu.html', templateUrl: 'app/navigation/templates/guacUserMenu.html',
@@ -59,7 +43,9 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
var $document = $injector.get('$document'); var $document = $injector.get('$document');
var $location = $injector.get('$location'); var $location = $injector.get('$location');
var authenticationService = $injector.get('authenticationService'); var authenticationService = $injector.get('authenticationService');
var connectionGroupService = $injector.get("connectionGroupService");
var guacNotification = $injector.get('guacNotification'); var guacNotification = $injector.get('guacNotification');
var permissionService = $injector.get("permissionService");
var userService = $injector.get('userService'); var userService = $injector.get('userService');
var userPageService = $injector.get('userPageService'); var userPageService = $injector.get('userPageService');
@@ -89,6 +75,22 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
*/ */
var document = $document[0]; var document = $document[0];
/**
* The root connection group, or null if the connection group hierarchy has
* not yet been loaded.
*
* @type ConnectionGroup
*/
var rootConnectionGroup = null;
/**
* All permissions associated with the current user, or null if the user's
* permissions have not yet been loaded.
*
* @type PermissionSet
*/
var permissions = null;
/** /**
* Whether the current user has sufficient permissions to change * Whether the current user has sufficient permissions to change
* his/her own password. If permissions have not yet been loaded, * his/her own password. If permissions have not yet been loaded,
@@ -149,30 +151,40 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
*/ */
var updateMenuItems = function updateMenuItems() { var updateMenuItems = function updateMenuItems() {
// Menu items are unknown until permissions and rootGroup are both available // Menu items are unknown until permissions and rootConnectionGroup are both available
if (!$scope.permissions || !$scope.rootGroup) { if (!permissions || !rootConnectionGroup) {
$scope.canChangePassword = null; $scope.canChangePassword = null;
$scope.pages = []; $scope.pages = [];
return; return;
} }
// Retrieve the main pages from the user page service // Retrieve the main pages from the user page service
$scope.pages = userPageService.getMainPages($scope.rootGroup, $scope.permissions); $scope.pages = userPageService.getMainPages(rootConnectionGroup, permissions);
// Check whether the current user can change their own password // Check whether the current user can change their own password
$scope.canChangePassword = PermissionSet.hasUserPermission( $scope.canChangePassword = PermissionSet.hasUserPermission(
$scope.permissions, PermissionSet.ObjectPermissionType.UPDATE, permissions, PermissionSet.ObjectPermissionType.UPDATE,
authenticationService.getCurrentUserID() authenticationService.getCurrentUserID()
); );
}; };
// Update available menu options when permissions are changed // Retrieve root group and all descendants
$scope.$watch('permissions', function permissionsChanged() { connectionGroupService.getConnectionGroupTree(ConnectionGroup.ROOT_IDENTIFIER)
.success(function rootConnectionGroupRetrieved(retrievedRootConnectionGroup) {
rootConnectionGroup = retrievedRootConnectionGroup;
// Navigate to home page, if not already there
var homePage = userPageService.getHomePage(rootConnectionGroup);
$location.url(homePage.url);
updateMenuItems(); updateMenuItems();
}); });
// Update available menu options when root group is changed // Retrieve current permissions
$scope.$watch('rootGroup', function rootGroupChanged() { permissionService.getPermissions(authenticationService.getCurrentUserID())
.success(function permissionsRetrieved(retrievedPermissions) {
permissions = retrievedPermissions;
updateMenuItems(); updateMenuItems();
}); });

View File

@@ -23,4 +23,4 @@
/** /**
* Module for generating and implementing user navigation options. * Module for generating and implementing user navigation options.
*/ */
angular.module('navigation', ['notification']); angular.module('navigation', ['notification', 'rest']);