From d4b7e2b8b608eaa8ad8e5a21eed8cd3bd92964e7 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Thu, 19 Apr 2018 05:30:51 -0400 Subject: [PATCH] GUACAMOLE-38: Use StringBuilder to gather up name. --- .../auth/quickconnect/utility/QCParser.java | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java b/extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java index ba6e3fdfe..7d5d7d422 100644 --- a/extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java +++ b/extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java @@ -19,6 +19,7 @@ package org.apache.guacamole.auth.quickconnect.utility; +import java.lang.StringBuilder; import java.net.URI; import java.net.URISyntaxException; import java.util.Arrays; @@ -164,23 +165,23 @@ public class QCParser { String port = config.getParameter("port"); String user = config.getParameter("username"); - String name = ""; + StringBuilder name = new StringBuilder(""); if (protocol != null && !protocol.isEmpty()) - name += protocol + "://"; + name.append(protocol).append("://"); if (user != null && !user.isEmpty()) - name += user + "@"; + name.append(user).append("@"); if (host != null && !host.isEmpty()) - name += host; + name.append(host); if (port != null && !port.isEmpty()) - name += ":" + port; + name.append(":").append(port); - name += "/"; + name.append("/"); - return name; + return name.toString(); } }