From d7d622051fd662563f700ccb35429a2b4285cc38 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Sat, 15 Dec 2018 13:57:56 -0500 Subject: [PATCH] GUACAMOLE-234: Change EqualityNode to PresenceNode for wildcard objectClass. --- .../apache/guacamole/auth/ldap/conf/ConfigurationService.java | 4 ++-- .../apache/guacamole/auth/ldap/group/UserGroupService.java | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/ConfigurationService.java b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/ConfigurationService.java index 67e78ce6e..588c60d4c 100644 --- a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/ConfigurationService.java +++ b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/conf/ConfigurationService.java @@ -22,8 +22,8 @@ package org.apache.guacamole.auth.ldap.conf; import com.google.inject.Inject; import java.util.Collections; import java.util.List; -import org.apache.directory.api.ldap.model.filter.EqualityNode; import org.apache.directory.api.ldap.model.filter.ExprNode; +import org.apache.directory.api.ldap.model.filter.PresenceNode; import org.apache.directory.api.ldap.model.message.AliasDerefMode; import org.apache.directory.api.ldap.model.name.Dn; import org.apache.guacamole.GuacamoleException; @@ -317,7 +317,7 @@ public class ConfigurationService { public ExprNode getUserSearchFilter() throws GuacamoleException { return environment.getProperty( LDAPGuacamoleProperties.LDAP_USER_SEARCH_FILTER, - new EqualityNode("objectClass","user") + new PresenceNode("objectClass") ); } diff --git a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java index 2fb31afc2..5eb375cb4 100644 --- a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java +++ b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java @@ -31,6 +31,7 @@ import org.apache.directory.api.ldap.model.exception.LdapInvalidAttributeValueEx import org.apache.directory.api.ldap.model.filter.EqualityNode; import org.apache.directory.api.ldap.model.filter.ExprNode; import org.apache.directory.api.ldap.model.filter.NotNode; +import org.apache.directory.api.ldap.model.filter.PresenceNode; import org.apache.directory.api.ldap.model.name.Dn; import org.apache.directory.ldap.client.api.LdapNetworkConnection; import org.apache.guacamole.auth.ldap.conf.ConfigurationService; @@ -87,7 +88,7 @@ public class UserGroupService { // Read any object as a group if LDAP is not being used for connection // storage (guacConfigGroup) - return new EqualityNode("objectClass","group"); + return new PresenceNode("objectClass"); }