From b8008baf6c32db68d4060c9fa75b774b075c1251 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Sun, 19 Jan 2020 19:41:55 -0800 Subject: [PATCH] GUACAMOLE-930: Remove unnecessary $scope.$apply(). $q and $http promises, such as the promise returned by languageService.getLanguages(), will already implicitly $apply() when needed. --- .../webapp/app/form/controllers/languageFieldController.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/guacamole/src/main/webapp/app/form/controllers/languageFieldController.js b/guacamole/src/main/webapp/app/form/controllers/languageFieldController.js index fdab13788..b7669ffc9 100644 --- a/guacamole/src/main/webapp/app/form/controllers/languageFieldController.js +++ b/guacamole/src/main/webapp/app/form/controllers/languageFieldController.js @@ -40,9 +40,7 @@ angular.module('form').controller('languageFieldController', ['$scope', '$inject // Retrieve defined languages languageService.getLanguages().then(function languagesRetrieved(languages) { - $scope.$apply(function updateLanguageOptions() { - $scope.languages = languages; - }); + $scope.languages = languages; }, requestService.DIE); // Interpret undefined/null as empty string