Fixed NPE in reader when connection closed during negotiaion. Added getRequiredProperty().

This commit is contained in:
Michael Jumper
2011-08-25 00:22:14 -07:00
parent de526911a5
commit e3260ca3e9
2 changed files with 28 additions and 0 deletions

View File

@@ -124,6 +124,10 @@ public class ReaderGuacamoleReader implements GuacamoleReader {
instructionStart = 0; instructionStart = 0;
} }
// If EOF, return EOF
if (instructionBuffer == null)
return null;
// Locate end-of-opcode and end-of-instruction // Locate end-of-opcode and end-of-instruction
int opcodeEnd = -1; int opcodeEnd = -1;
int instructionEnd = -1; int instructionEnd = -1;

View File

@@ -98,4 +98,28 @@ public class GuacamoleProperties {
} }
/**
* Given a GuacamoleProperty, parses and returns the value set for that
* property in guacamole.properties. An exception is thrown if the value
* is not provided.
*
* @param <Type> The type that the given property is parsed into.
* @param property The property to read from guacamole.properties.
* @return The parsed value of the property as read from
* guacamole.properties.
* @throws GuacamoleException If an error occurs while parsing the value
* for the given property in
* guacamole.properties, or if the property is
* not specified.
*/
public static <Type> Type getRequiredProperty(GuacamoleProperty<Type> property)
throws GuacamoleException {
Type value = getProperty(property);
if (value == null)
throw new GuacamoleException("Property " + property.getName() + " is required.");
return value;
}
} }