safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-232: Mark key as implicitly pressed only when pressed due to another, identifiable key event.

Browse Source
This commit is contained in:
Michael Jumper
2018-10-03 21:30:02 -07:00
parent f46f52dbac
commit e3c1b6ac98
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
guacamole-common-js/src/main/webapp/modules/Keyboard.js
View File

@@ -964,20 +964,23 @@ Guacamole.Keyboard = function Keyboard(element) {
// Press if modifier is implicitly pressed // Press if modifier is implicitly pressed
else if (!remoteState && localState) { else if (!remoteState && localState) {
// Verify that modifier flag isn't set due to another version of // Verify that modifier flag isn't already pressed or already set
// the same key being held down // due to another version of the same key being held down
for (i = 0; i < keysyms.length; i++) { for (i = 0; i < keysyms.length; i++) {
if (guac_keyboard.pressed[keysyms[i]]) if (guac_keyboard.pressed[keysyms[i]])
return; return;
} }
// Press key and mark as implicitly pressed (if not already // Mark as implicitly pressed only if there is other information
// explicitly pressed) // within the key event relating to a different key. Some
// platforms, such as iOS, will send essentially empty key events
// for modifier keys, using only the modifier flags to signal the
// identity of the key.
var keysym = keysyms[0]; var keysym = keysyms[0];
if (!guac_keyboard.pressed(keysym)) { if (keyEvent.keysym)
implicitlyPressed[keysym] = true; implicitlyPressed[keysym] = true;
guac_keyboard.press(keysym);
} guac_keyboard.press(keysym);
} }