safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-07 13:41:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-1224: Log identifiers of extensions reporting authentication failures.

Browse Source
This commit is contained in:
Michael Jumper
2022-10-03 15:57:11 -07:00
parent 818471ac84
commit e5761551e4
1 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
guacamole/src/main/java/org/apache/guacamole/event/EventLoggingListener.java
View File

@@ -22,6 +22,7 @@ package org.apache.guacamole.event;
import javax.annotation.Nonnull; import javax.annotation.Nonnull;
import org.apache.guacamole.GuacamoleException; import org.apache.guacamole.GuacamoleException;
import org.apache.guacamole.GuacamoleResourceNotFoundException; import org.apache.guacamole.GuacamoleResourceNotFoundException;
import org.apache.guacamole.net.auth.AuthenticationProvider;
import org.apache.guacamole.net.auth.Credentials; import org.apache.guacamole.net.auth.Credentials;
import org.apache.guacamole.net.auth.credentials.GuacamoleInsufficientCredentialsException; import org.apache.guacamole.net.auth.credentials.GuacamoleInsufficientCredentialsException;
import org.apache.guacamole.net.event.ApplicationShutdownEvent; import org.apache.guacamole.net.event.ApplicationShutdownEvent;
@@ -144,6 +145,8 @@ public class EventLoggingListener implements Listener {
*/ */
private void logFailure(AuthenticationFailureEvent event) { private void logFailure(AuthenticationFailureEvent event) {
AuthenticationProvider authProvider = event.getAuthenticationProvider();
Credentials creds = event.getCredentials(); Credentials creds = event.getCredentials();
String username = creds.getUsername(); String username = creds.getUsername();
@@ -154,14 +157,27 @@ public class EventLoggingListener implements Listener {
else if (username == null || username.isEmpty()) else if (username == null || username.isEmpty())
logger.debug("Anonymous authentication attempt from {} failed: {}", logger.debug("Anonymous authentication attempt from {} failed: {}",
new RemoteAddress(creds), new Failure(event)); new RemoteAddress(creds), new Failure(event));
else if (event.getFailure() instanceof GuacamoleInsufficientCredentialsException) else if (event.getFailure() instanceof GuacamoleInsufficientCredentialsException) {
if (authProvider != null)
logger.debug("Authentication attempt from {} for user \"{}\" "
+ "requires additional credentials to continue: {} "
+ "(requested by \"{}\")", new RemoteAddress(creds),
username, new Failure(event), authProvider.getIdentifier());
else
logger.debug("Authentication attempt from {} for user \"{}\" " logger.debug("Authentication attempt from {} for user \"{}\" "
+ "requires additional credentials to continue: {}", + "requires additional credentials to continue: {}",
new RemoteAddress(creds), username, new Failure(event)); new RemoteAddress(creds), username, new Failure(event));
}
else {
if (authProvider != null)
logger.warn("Authentication attempt from {} for user \"{}\" "
+ "failed: {} (rejected by \"{}\")", new RemoteAddress(creds),
username, new Failure(event), authProvider.getIdentifier());
else else
logger.warn("Authentication attempt from {} for user \"{}\" " logger.warn("Authentication attempt from {} for user \"{}\" "
+ "failed: {}", new RemoteAddress(creds), username, + "failed: {}", new RemoteAddress(creds), username,
new Failure(event)); new Failure(event));
}
} }