safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

GUACAMOLE-1967: Remove duplicate wheel handler registrations.

Browse Source 
Modern-day browsers abide the standardized wheel event (typed `WheelEvent`),
however to support older browsers the legacy `DOMMouseScroll` (FireFox) and
`mousewheel` (all others) events are also being registered.

However modern browsers support both the modern event as well as the legacy,
which results in the wheel handler being registered multiple times. This results
in the wheel handler firing twice instead of once, causing excessive scrolling.

This change separates the event registration such that either the modern or the
legacy events are registered, and not both.
This commit is contained in:
Christopher Speck
2024-07-11 14:47:55 -04:00
parent 62820f12a3
commit e5817c7004
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
guacamole-common-js/src/main/webapp/modules/Mouse.js
View File

@@ -258,9 +258,16 @@ Guacamole.Mouse = function Mouse(element) {
}
element.addEventListener('DOMMouseScroll', mousewheel_handler, false);
element.addEventListener('mousewheel', mousewheel_handler, false);
if (window.WheelEvent) {
// All modern browsers support wheel events.
element.addEventListener('wheel', mousewheel_handler, false);
}
else {
// Legacy FireFox wheel events.
element.addEventListener('DOMMouseScroll', mousewheel_handler, false);
// Legacy Chrome/IE/other wheel events.
element.addEventListener('mousewheel', mousewheel_handler, false);
}
/**
* Whether the browser supports CSS3 cursor styling, including hotspot