From f54af15f0b89268bdb5541407ad9053e18b33c74 Mon Sep 17 00:00:00 2001 From: Nick Couchman Date: Tue, 28 Mar 2017 11:29:46 -0400 Subject: [PATCH] GUACAMOLE-101: Avoid using both StringBuilder and String concatenation. --- .../java/org/apache/guacamole/auth/ldap/user/UserService.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java index 94763e6f5..d2c0cd725 100644 --- a/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java +++ b/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java @@ -90,7 +90,9 @@ public class UserService { StringBuilder userSearchFilter = new StringBuilder(); userSearchFilter.append("(&"); userSearchFilter.append(confService.getUserSearchFilter()); - userSearchFilter.append("(" + escapingService.escapeLDAPSearchFilter(usernameAttribute) + "=*)"); + userSearchFilter.append("("); + userSearchFilter.append(escapingService.escapeLDAPSearchFilter(usernameAttribute)); + userSearchFilter.append("=*)"); userSearchFilter.append(")");