Commit Graph

5505 Commits

Author SHA1 Message Date
Michael Jumper
6649c5d334 GUACAMOLE-884: Document implications of using drawStream() vs. the other drawing functions. 2019-09-29 22:13:19 -07:00
Michael Jumper
4e130d2afd GUACAMOLE-884: Leverage createImageBitmap() for reading image data where supported.
Some browsers suffer from a memory leak when reading image data
repeatedly using the Image object. Reading from Blobs does not exhibit
the same behavior. While reading from Blobs has previously been seen to
perform poorly compared to data URIs, this was observed when reading
using createObjectURL(). The createImageBitmap() function appears to
perform identically to reading data URIs using Image.
2019-09-29 21:57:05 -07:00
Virtually Nick
bad20e1a6c GUACAMOLE-817: Merge reset keyboard state on navigation and form submission. 2019-09-29 20:32:50 -04:00
Michael Jumper
a4a89e983a GUACAMOLE-817: Reset keyboard state on navigation and form submission.
Firefox, and perhaps other browsers, does not fire a keyup event for
keys involved in submitting a form. This results in the enter key being
stuck in a pressed state if it is used to submit Guacamole's login
form.

Keyboard state should be reset whenever keyboard state cannot be
reliably maintained. This is already done for loss of window focus, but
should also be done for form submission (this specific case) and
navigation to a different page (generic catch-all).
2019-09-29 12:32:29 -07:00
Michael Jumper
5ff81f7735 Merge 1.1.0 changes back to master.
Conflicts:

 * extensions/guacamole-auth-cas/src/main/resources/guac-manifest.json
 * extensions/guacamole-auth-duo/src/main/resources/guac-manifest.json
 * extensions/guacamole-auth-openid/src/main/resources/guac-manifest.json
 * extensions/guacamole-auth-quickconnect/src/main/resources/guac-manifest.json
 * extensions/guacamole-auth-radius/src/main/resources/guac-manifest.json
 * extensions/guacamole-auth-totp/src/main/resources/guac-manifest.json
 * guacamole/src/main/webapp/translations/de.json
2019-09-09 18:57:01 -07:00
Mike Jumper
981adc94e6 GUACAMOLE-699: Merge changes bringing German translations up-to-date. 2019-09-09 18:52:53 -07:00
Mike Jumper
7a68a78a89 GUACAMOLE-870: Merge changes using CHARINDEX() instead of POSITION() for SQL Server.
SQL Server does not support the ANSI SQL POSITION() function, instead providing its own non-standard equivalent: CHARINDEX().
2019-09-07 13:42:41 -07:00
Nick Couchman
e5b93feb1e GUACAMOLE-870: Replace POSITION with CHARINDEX for SQL Server. 2019-09-05 14:44:46 -04:00
Michael Jumper
a00baf6d89 Merge 1.1.0 changes back to master. 2019-09-01 15:07:38 -07:00
Mike Jumper
276f8d4f0f GUACAMOLE-234: Merge changes maintaining open LDAP connection following call to bindAs(). 2019-09-01 15:07:03 -07:00
Mike Jumper
a9e9f506c7 GUACAMOLE-514: Merge parameter definition and translations for VNC "username" field. 2019-08-27 11:52:18 -07:00
Nick Couchman
610ed6934e GUACAMOLE-234: Fix bind issue that occurs using try-with-resources. 2019-08-26 11:19:35 -04:00
Virtually Nick
9715ab12eb GUACAMOLE-514: Correct username field type and add translations. 2019-08-23 21:05:48 -04:00
Virtually Nick
e58101997f Merge 1.1.0 changes back to master. 2019-08-19 08:17:29 -04:00
Virtually Nick
7fd9bf49a5 GUACAMOLE-630: Merge use singleton instance of Pickr for all color input fields. 2019-08-19 08:16:22 -04:00
Mike Jumper
339c920a89 GUACAMOLE-684: Merge changes giving tentative acceptance of credentials priority over complete refusal.
As described in the discussion surrounding the original pull request:

 * An extension throws `GuacamoleInsufficientCredentialsException`
   specifically to indicate tentative acceptance of the credentials
   passed thus far.
 * Just as such an extension that fully accepts credentials takes
   priority over an extension that refuses to accept the same, it makes
   sense to allow an extension that *tentatively* accepts those credentials
   to also take priority.

With the above perspective, authentication result priorities are as
follows, with ties broken by the inherent order of the auth providers:

 1. Acceptance (returning an `AuthenticedUser` instance).
 2. Tentative acceptance (throwing
    `GuacamoleInvalidCredentialsException`).
 3. Complete refusal (any other subclass of
    `GuacamoleCredentialsException`).
 4. Neither refusal nor acceptance (returning `null`).

See: https://github.com/apache/guacamole-client/pull/352
2019-08-19 00:11:19 -07:00
Michael Jumper
93ba19ac26 GUACAMOLE-630: Create a new injector for field type instances only if needed.
Creating a new injector re-initializes services and providers within
its modules. If those services or providers rely on being singletons
(as colorPickerService does), this produces unexpected behavior.
2019-08-18 22:00:16 -07:00
Michael Jumper
83f1849215 GUACAMOLE-630: Migrate guacInputColor to singleton instance of Pickr. 2019-08-18 21:32:58 -07:00
leetxyz
5ac68c3f72 GUACAMOLE-699: Fix language ordering, add de.json to auth-jdbc-*, fix intendation 2019-08-15 18:09:30 +02:00
Mike Jumper
df8b8ab0e6 GUACAMOLE-769: Merge fix for regression in appearance of RADIUS challenge/response interface. 2019-08-13 12:15:30 -07:00
Virtually Nick
e86e415493 GUACAMOLE-769: Add back empty translation string. 2019-08-13 14:57:41 -04:00
Mike Jumper
c370d34524 GUACAMOLE-774: Merge correction for Java 9+ compatibility in RADIUS build. 2019-08-13 11:57:21 -07:00
Virtually Nick
95ec3c73ce GUACAMOLE-774: Different approach to loading MD4 support. 2019-08-13 14:11:38 -04:00
Virtually Nick
f7d836da9e GUACAMOLE-774: Deal with deprecated Provider constructor. 2019-08-13 13:45:36 -04:00
Virtually Nick
1b6f0bdcc1 GUACAMOLE-774: Fix deprecation issue with Java 9 and up. 2019-08-13 06:31:59 -04:00
Mike Jumper
7f581a1536 GUACAMOLE-774: Merge dynamic loading of MD4 support (for RADIUS MSCHAPv1/2). 2019-08-12 18:08:36 -07:00
Virtually Nick
e5fab49d75 GUACAMOLE-774: Remove unnecessary null checks. 2019-08-12 20:13:37 -04:00
leetxyz
222ac78576 GUACAMOLE-699: Various fixes according to comments in PR 2019-08-12 21:02:36 +02:00
Michael Jumper
25c87922d5 Merge 1.1.0 changes back to master. 2019-08-12 10:15:49 -07:00
Mike Jumper
c643fe9610 GUACAMOLE-234: Merge fixes for LDAP resource leak regressions. 2019-08-12 10:15:13 -07:00
Virtually Nick
749da7d29c GUACAMOLE-234: Fix resource leaks in new LDAP code. 2019-08-12 13:03:31 -04:00
Virtually Nick
a4495cf6ec Merge 1.1.0 changes to master. 2019-08-11 19:05:11 -04:00
Virtually Nick
1d205fd451 GUACAMOLE-360: Merge add support for joining active connections without share links. 2019-08-11 19:03:05 -04:00
Mike Jumper
97d550de8e GUACAMOLE-769: Merge cleanup of RADIUS challenge response interface. 2019-08-11 15:58:05 -07:00
Michael Jumper
6e439bf827 Merge 1.1.0 changes back to master. 2019-08-11 15:54:36 -07:00
Mike Jumper
2d86bbf5e6 GUACAMOLE-234: Merge migration from JLDAP to Apache Directory API. 2019-08-11 15:53:58 -07:00
Virtually Nick
59c46da5b5 GUACAMOLE-769: Get the value and avoid splitting the string. 2019-08-11 18:49:45 -04:00
Virtually Nick
516963a162 GUACAMOLE-769: Clean up documentation and add challenge variable comment. 2019-08-11 18:49:45 -04:00
Virtually Nick
11f7a7f3c7 GUACAMOLE-234: Update license files. 2019-08-11 18:37:43 -04:00
Michael Jumper
4768f66a8b GUACAMOLE-360: When joining an active connection, retrieve name and protocol from underlying connection. 2019-08-11 14:30:31 -07:00
Michael Jumper
04182391e9 GUACAMOLE-360: Add interface for connecting to active connections from "Active Sessions" tab. 2019-08-11 14:30:31 -07:00
Michael Jumper
1645516156 GUACAMOLE-360: Add TunnelRequestService support for joining active connections. 2019-08-11 14:30:31 -07:00
Michael Jumper
1c7242b800 GUACAMOLE-360: Refactor TunnelRequestService to handle any Connectable supported by TunnelRequestType. 2019-08-11 14:30:31 -07:00
Michael Jumper
403431bf92 GUACAMOLE-360: Add support for joining active connections to the database auth. 2019-08-11 14:30:31 -07:00
Virtually Nick
7dceecd7f3 GUACAMOLE-769: Finish removing custom RADIUS challenge field. 2019-08-11 14:33:17 -04:00
Virtually Nick
30591dcc2e GUACAMOLE-769: Use standard password field for RADIUS challenge. 2019-08-11 14:25:15 -04:00
Virtually Nick
8b172a98fc GUACAMOLE-234: Fix style, debug messages, and logger output. 2019-08-10 22:14:56 -04:00
Michael Jumper
a59e20eb8d GUACAMOLE-360: Allow connections to active connections at API level. 2019-08-10 17:19:29 -07:00
Virtually Nick
8c1a3f3435 GUACAMOLE-234: Remove stray catch block. 2019-08-10 13:57:51 -04:00
Virtually Nick
5ea518a390 GUACAMOLE-234: Update to latest available Apache Directory API. 2019-08-10 13:57:51 -04:00