Commit Graph

4965 Commits

Author SHA1 Message Date
Michael Jumper
bcbac1fb57 GUACAMOLE-524: Ensure all guacamole-ext classes implementing connect() use the old connect() as their basis. Overriding the old connect() will not have the expected effect otherwise. 2019-01-22 15:49:16 -08:00
Michael Jumper
feecb6301f GUACAMOLE-524: Declare deprecation of old connect() within guacamole-ext. 2019-01-22 15:46:43 -08:00
Michael Jumper
a28b3c393a GUACAMOLE-524: Do not interpret tokens in SimpleUserContext if interpretTokens is false. 2019-01-22 14:25:27 -08:00
Michael Jumper
05553ec918 GUACAMOLE-524: Internally replace Connectable with an ABI-compatible version.
Defining an ABI-compatible version of Connectable at the guacamole-ext
level is problematic as concrete implementations of the interface will
suddenly compile despite having no implementation of connect() at all.

We can instead rely on the web application to ensure binary
compatibility, leaving guacamole-ext to define the interface that new
code should use.
2019-01-22 12:29:03 -08:00
Michael Jumper
9d74d9911e GUACAMOLE-524: Correct JavaDoc references to previous iteration of API rework. 2019-01-22 00:28:44 -08:00
Michael Jumper
49cd4e5531 GUACAMOLE-524: Clarify and document SimpleConnection implementation. 2019-01-21 22:04:44 -08:00
Michael Jumper
6be722ed9d GUACAMOLE-524: Require usages of SimpleConnection to explicitly request automatic interpretation of parameter tokens. Do not enable by default.
Previous implementations of SimpleConnection did not interpret parameter
tokens automatically. Adding that behavior now could have security
implications for downstream users of the class if parameter values may
unexpectedly contain substrings which would be interpreted as tokens,
particularly if parameter values are built from untrusted input.
2019-01-21 19:55:33 -08:00
Michael Jumper
7e67dde751 GUACAMOLE-524: Leverage thread-local storage to allow overriding the deprecated connect() function to have the expected effect within subclasses of SimpleConnection. 2019-01-21 17:52:54 -08:00
Michael Jumper
b638387920 GUACAMOLE-524: Provide distinct, documented, internal access to raw GuacamoleConfiguration within SimpleConnection.
While raw, internal access to the GuacamoleConfiguration was originally
present in older versions of SimpleConnection, this access was
undocumented and could result in unexpected behavior if the default
constructor was used, getConfiguration() was overridden, or
setConfiguration() was called.
2019-01-21 17:38:24 -08:00
Michael Jumper
4a1527b1d4 GUACAMOLE-524: Provide bridge implementations of both old and new versions of connect() for sake of compatibility. 2019-01-20 13:30:55 -08:00
Virtually Nick
59b1ccc732 GUACAMOLE-699: Merge add helper script for verifying translations 2019-01-13 16:20:09 -05:00
Mike Jumper
fe6203a054 GUACAMOLE-683: Merge Docker image support for OpenID authentication. 2019-01-13 02:14:55 -08:00
Michael Jumper
fe36014e97 GUACAMOLE-699: Add helper script for verifying translations. 2019-01-12 16:36:58 -08:00
Krzysztof Adamski
b971c61193 GUACAMOLE-683: Introduce support for openid authentication in docker build 2019-01-12 20:26:05 +01:00
Michael Jumper
78f1ae1b4e GUACAMOLE-682: Merge support for specfying the Maven build profile when building the Docker image. 2018-12-24 09:06:41 -08:00
Joern Lentes
5fb537b707 GUACAMOLE-682: added parameter documentation 2018-12-23 22:09:55 +01:00
Joern Lentes
516dbfd5c7 GUACAMOLE-682: adapted indent to be consistent 2018-12-22 09:58:27 +01:00
Joern Lentes
2e98f6f8a0 GUACAMOLE-682: added comment with example to build with RADIUS 2018-12-21 15:04:28 +01:00
Joern Lentes
95611f2d93 GUACAMOLE-682: fix env variable passing 2018-12-21 14:50:46 +01:00
Joern Lentes
0f31028565 GUACAMOLE-682: add option to include RADIUS authentication in docker
To include library for RADIUS authentication in the docker image the
build needs to activate the maven profile "lgpl-extentions" and copy
the library into the image.
The docker start script needs to pass through settings and link the
library to GUACAMOLE_HOME.
2018-12-21 11:15:25 +01:00
Nick Couchman
fd2198d62b GUACAMOLE-674: Merge add variable for LDAP member attribute to Docker start script. 2018-12-07 04:49:54 -05:00
Joern Lentes
0f59f6efc8 GUACAMOLE-674: added env variable for member attribute 2018-12-07 10:08:51 +01:00
Nick Couchman
a1e6db170f GUACAMOLE-598: Merge ignore if current user has no associated data. 2018-12-06 07:01:31 -05:00
Michael Jumper
caf07a92a9 Merge 1.0.0 changes back to master. 2018-12-05 14:40:34 -08:00
Michael Jumper
801a5df9f1 GUACAMOLE-526: Merge changes correcting regression in CAS due to AngularJS update.
Including `ngRoute` as a dependency of a module which defines a custom
field type will always result in the following error:

    Unknown provider: $rootElementProvider <- $rootElement <- $location <- $route <- $location

This seems to be due to the manner in which the injector is created for
field types. `$rootElementProvider` is not available for injection in
the context of the injector of a custom field. This is generally OK, but
`ngRoute` transitively depends on `$rootElementProvider`. Since
`$rootElementProvider` cannot be injected within the context of a field
type, no field type can depend on ngRoute without causing this error.

Note that extensions can still leverage `ngRoute` (this is already done
by the OpenID support). It just cannot be declared as a dependency of a
module containing a custom field type.
2018-12-05 14:32:37 -08:00
Nick Couchman
29982e3a85 GUACAMOLE-526: Clean up unused code and minor errors. 2018-12-04 19:28:18 -05:00
Nick Couchman
df8c07c187 GUACAMOLE-526: Fix loading of CAS ticket field and redirection. 2018-12-04 19:28:14 -05:00
Michael Jumper
ef0cb1ee7a GUACAMOLE-598: Ignore if current user has no associated data. Authentication providers are not required to provide data for the users they authenticate. 2018-12-04 13:22:16 -08:00
Michael Jumper
fc457c080d Merge 1.0.0 changes back to master. 2018-12-03 07:32:21 -08:00
Michael Jumper
a967ffa41c GUACAMOLE-670: Merge changes correcting conflicting versions of SLF4J. 2018-12-03 07:30:23 -08:00
Nick Couchman
95dfb5e765 GUACAMOLE-670: Use exclusion to block loading of duplicate slf4j. 2018-12-03 07:35:22 -05:00
Nick Couchman
73744d22f9 GUACAMOLE-670: Add slf4j logging to modules to avoid pulling in conflicting versions. 2018-12-02 15:43:12 -05:00
Nick Couchman
823bbeace1 Merge 1.0.0 changes back to master. 2018-11-09 20:26:05 -05:00
Nick Couchman
001ece14e2 GUACAMOLE-220: Merge correct translation strings for user group "disabled" attribute. 2018-11-09 20:24:24 -05:00
James Muehlner
d4f58f2c0d Merge changes from 1.0.0 back to master. 2018-11-08 22:18:28 -08:00
James Muehlner
4d858451c9 GUACAMOLE-656: Merge maven-surefire-plugin build fix. 2018-11-08 22:16:58 -08:00
Michael Jumper
95b5fdccdc GUACAMOLE-656: Explicitly depend on maven-surefire-plugin 3.0.0-M1 due to SUREFIRE-1588. 2018-11-08 22:09:35 -08:00
James Muehlner
756ec2fcc4 Merge 1.0.0 changes back to master. 2018-11-08 21:26:43 -08:00
James Muehlner
c0008aed62 GUACAMOLE-220: Merge LDAP user group support. 2018-11-08 20:42:51 -08:00
Michael Jumper
b355106c77 GUACAMOLE-220: Remove unnecessary explicit type parameters. 2018-11-08 20:11:17 -08:00
Michael Jumper
a4d6f62df0 GUACAMOLE-220: Reword description of getGroupSearchFilter() to be less brain-meltingly difficult to read. 2018-11-08 19:55:49 -08:00
Michael Jumper
83033cad65 GUACAMOLE-220: Use JavaDoc "{@link Map}" to point to Map interface. 2018-11-08 19:45:25 -08:00
Michael Jumper
3c5594db2e GUACAMOLE-220: Group attribute "disabled" controls whether the group has any effect, not whether login is allowed. 2018-11-03 17:24:06 -07:00
Michael Jumper
2d6ba84a3d GUACAMOLE-220: Refactor default behavior of SimpleUser and SimpleUserGroup into AbstractUser and AbstractUserGroup. 2018-11-03 14:52:24 -07:00
Michael Jumper
90a6d8e371 GUACAMOLE-220: Clarify usage of SimpleUser and SimpleUserGroup. 2018-11-03 14:14:04 -07:00
Michael Jumper
d533de118f GUACAMOLE-220: Add EMPTY_SET convenience constant to all core set interfaces. 2018-11-03 14:08:46 -07:00
Michael Jumper
d10256e151 GUACAMOLE-220: Deprecate built-in support for storage of permissions in SimpleUser. Add convenience constructors for SimpleObjectPermissionSet. 2018-11-03 13:58:50 -07:00
Michael Jumper
aa0c654231 GUACAMOLE-220: Retrieve user groups from LDAP. Take immediate group membership into account. 2018-11-03 12:41:54 -07:00
Michael Jumper
bdc792603d GUACAMOLE-220: Add configuration property for setting the attributes which uniquely identify user groups within LDAP. 2018-11-03 12:41:54 -07:00
Michael Jumper
7c57b448bb GUACAMOLE-220: Define generic service for executing LDAP queries. Refactor existing services to remove common code. 2018-11-03 12:41:54 -07:00