Refactor a bit more for testing, update tests

main.go

@@ -5,44 +5,56 @@ import (
 	"time"
 )
 
+func checkMonitors(config *Config) {
+	for _, monitor := range config.Monitors {
+		if monitor.ShouldCheck() {
+			_, alertNotice := monitor.Check()
+
+			// Should probably consider refactoring everything below here
+			if alertNotice != nil {
+				log.Printf("DEBUG: Recieved an alert notice: %v", alertNotice)
+				alertNames := monitor.GetAlertNames(alertNotice.IsUp)
+				if alertNames == nil {
+					// TODO: Should this be a panic? Should this be validated against? Probably
+					log.Printf("WARNING: Found alert, but no alert mechanisms exist: %v", alertNotice)
+				}
+				for _, alertName := range alertNames {
+					if alert, ok := config.Alerts[alertName]; ok {
+						output, err := alert.Send(*alertNotice)
+						if err != nil {
+							log.Printf(
+								"ERROR: Alert '%s' failed. result=%v: output=%s",
+								alert.Name,
+								err,
+								output,
+							)
+							// TODO: Maybe return this error instead of panicking here
+							log.Fatalf(
+								"ERROR: Unsuccessfully triggered alert '%s'. "+
+									"Crashing to avoid false negatives: %v",
+								alert.Name,
+								err,
+							)
+						}
+					} else {
+						// TODO: Maybe panic here. Also, probably validate up front
+						log.Printf("ERROR: Alert with name '%s' not found", alertName)
+					}
+				}
+			}
+		}
+	}
+}
+
 func main() {
 	config, err := LoadConfig("config.yml")
 	if err != nil {
 		log.Fatalf("Error loading config: %v", err)
 	}
 
+	// Start main loop
 	for {
-		for _, monitor := range config.Monitors {
-			if monitor.ShouldCheck() {
-				_, alertNotice := monitor.Check()
-
-				// Should probably consider refactoring everything below here
-				if alertNotice != nil {
-					//log.Printf("Recieved an alert notice: %v", alertNotice)
-					var alerts []string
-					if alertNotice.IsUp {
-						alerts = monitor.AlertUp
-						log.Printf("Alert up: %v", monitor.AlertUp)
-					} else {
-						alerts = monitor.AlertDown
-						log.Printf("Alert down: %v", monitor.AlertDown)
-					}
-					if alerts == nil {
-						log.Printf("WARNING: Found alert, but no alert mechanism: %v", alertNotice)
-					}
-					for _, alertName := range alerts {
-						if alert, ok := config.Alerts[alertName]; ok {
-							_, err := alert.Send(*alertNotice)
-							if err != nil {
-								panic(err)
-							}
-						} else {
-							log.Printf("WARNING: Could not find alert for %s", alertName)
-						}
-					}
-				}
-			}
-		}
+		checkMonitors(&config)
 
 		sleepTime := time.Duration(config.CheckInterval) * time.Second
 		time.Sleep(sleepTime)