safebox/guacamole-client
4
0
Fork 0
mirror of https://github.com/gyurix1968/guacamole-client.git synced 2025-09-06 13:17:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

As keydown/keypress are handled via deferred setTimeout(), so should keyup (otherwise, there's a race condition that keyup might happen before the deferred handling of keydown/keypress, and the key might be effectively stuck down or in a repeating state).

Browse Source
This commit is contained in:
Michael Jumper
2012-05-16 13:36:28 -07:00
parent aa7c38be32
commit a650a4a6ec
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
guacamole-common-js/src/main/resources/keyboard.js
View File

@@ -511,21 +511,27 @@ Guacamole.Keyboard = function(element) {
if (window.event) keynum = window.event.keyCode;
else if (e.which) keynum = e.which;
// Ctrl/Alt/Shift
if (keynum == 16) guac_keyboard.modifiers.shift = false;
else if (keynum == 17) guac_keyboard.modifiers.ctrl = false;
else if (keynum == 18) guac_keyboard.modifiers.alt = false;
else
stopRepeat();
// Defer handling of keyup (otherwise, keyup may happen before
// deferred handling of keydown/keypress).
window.setTimeout(function() {
// Get corresponding character
var lastKeyDownChar = keydownChar[keynum];
// Ctrl/Alt/Shift
if (keynum == 16) guac_keyboard.modifiers.shift = false;
else if (keynum == 17) guac_keyboard.modifiers.ctrl = false;
else if (keynum == 18) guac_keyboard.modifiers.alt = false;
else
stopRepeat();
// Clear character record
keydownChar[keynum] = null;
// Get corresponding character
var lastKeyDownChar = keydownChar[keynum];
// Send release event
sendKeyReleased(lastKeyDownChar);
// Clear character record
keydownChar[keynum] = null;
// Send release event
sendKeyReleased(lastKeyDownChar);
}, 0);
};