Commit Graph

5160 Commits

Author SHA1 Message Date
Michael Jumper
cb53b17afb GUACAMOLE-938: Refactor LDAP connect/bind process such that the same code is used for all LDAP connection attempts, including referrals. 2020-01-25 14:36:30 -08:00
Michael Jumper
15b631514d GUACAMOLE-938: Remove disconnect() utility function. Closing an LdapNetworkConnection cannot throw an IOException. 2020-01-24 22:52:17 -08:00
Virtually Nick
9c72a87c6a GUACAMOLE-936: Merge ensure LDAP connections for followed referrals are always closed 2020-01-24 04:51:35 -05:00
Michael Jumper
5c2f44ae3a GUACAMOLE-936: Clean up referral logic and logging. Ensure associated LDAP connections are always closed. 2020-01-24 01:12:00 -08:00
Virtually Nick
67bd94b1f8 GUACAMOLE-937: Merge return null on bindAs() failures. 2020-01-24 02:31:26 -05:00
Michael Jumper
2cb0efeda6 GUACAMOLE-937: Return null on bindAs() failures. Rely on caller to interpret and handle failures.
Throwing GuacamoleInvalidCredentialsException breaks separation of
concerns (bindAs() shouldn't assume that it's being used during login
and that credentials given are the Guacamole user's credentials), and
has unintended side effects (throwing subclasses of
GuacamoleUnauthorizedException causes implicit session invalidation).
2020-01-23 23:24:47 -08:00
Virtually Nick
3805a7527d GUACAMOLE-936: Merge LdapNetworkConnection must be closed 2020-01-24 02:18:12 -05:00
Michael Jumper
00327706b0 GUACAMOLE-936: Each LdapNetworkConnection must be closed or threads are leaked, causing Tomcat to fail to shutdown. 2020-01-22 22:07:11 -08:00
Virtually Nick
09b2400d89 GUACAMOLE-929: Merge update copyright date to 2020. 2020-01-20 03:47:53 -05:00
Virtually Nick
e2e5853991 GUACAMOLE-930: Merge remove unnecessary $scope.$apply(). 2020-01-20 03:33:56 -05:00
Michael Jumper
b8008baf6c GUACAMOLE-930: Remove unnecessary $scope.$apply().
$q and $http promises, such as the promise returned by
languageService.getLanguages(), will already implicitly $apply() when
needed.
2020-01-19 19:41:55 -08:00
Michael Jumper
76c1b0f9bb GUACAMOLE-929: Update copyright date to 2020. 2020-01-19 13:39:54 -08:00
Mike Jumper
51de21b745 GUACAOMLE-893: Merge fix for regression in LDAP filter generation. 2019-10-11 10:42:54 -07:00
Virtually Nick
a037146a87 GUACAMOLE-893: Fix issue where just checking for attribute presence. 2019-10-10 20:53:07 -04:00
Virtually Nick
10b3adcd83 GUACAMOLE-893: Fix regression in LDAP causing null filter value to be sent. 2019-10-09 14:53:34 -04:00
Mike Jumper
981adc94e6 GUACAMOLE-699: Merge changes bringing German translations up-to-date. 2019-09-09 18:52:53 -07:00
Mike Jumper
276f8d4f0f GUACAMOLE-234: Merge changes maintaining open LDAP connection following call to bindAs(). 2019-09-01 15:07:03 -07:00
Nick Couchman
610ed6934e GUACAMOLE-234: Fix bind issue that occurs using try-with-resources. 2019-08-26 11:19:35 -04:00
Virtually Nick
7fd9bf49a5 GUACAMOLE-630: Merge use singleton instance of Pickr for all color input fields. 2019-08-19 08:16:22 -04:00
Michael Jumper
93ba19ac26 GUACAMOLE-630: Create a new injector for field type instances only if needed.
Creating a new injector re-initializes services and providers within
its modules. If those services or providers rely on being singletons
(as colorPickerService does), this produces unexpected behavior.
2019-08-18 22:00:16 -07:00
Michael Jumper
83f1849215 GUACAMOLE-630: Migrate guacInputColor to singleton instance of Pickr. 2019-08-18 21:32:58 -07:00
leetxyz
5ac68c3f72 GUACAMOLE-699: Fix language ordering, add de.json to auth-jdbc-*, fix intendation 2019-08-15 18:09:30 +02:00
leetxyz
222ac78576 GUACAMOLE-699: Various fixes according to comments in PR 2019-08-12 21:02:36 +02:00
Mike Jumper
c643fe9610 GUACAMOLE-234: Merge fixes for LDAP resource leak regressions. 2019-08-12 10:15:13 -07:00
Virtually Nick
749da7d29c GUACAMOLE-234: Fix resource leaks in new LDAP code. 2019-08-12 13:03:31 -04:00
Virtually Nick
1d205fd451 GUACAMOLE-360: Merge add support for joining active connections without share links. 2019-08-11 19:03:05 -04:00
Mike Jumper
2d86bbf5e6 GUACAMOLE-234: Merge migration from JLDAP to Apache Directory API. 2019-08-11 15:53:58 -07:00
Virtually Nick
11f7a7f3c7 GUACAMOLE-234: Update license files. 2019-08-11 18:37:43 -04:00
Michael Jumper
4768f66a8b GUACAMOLE-360: When joining an active connection, retrieve name and protocol from underlying connection. 2019-08-11 14:30:31 -07:00
Michael Jumper
04182391e9 GUACAMOLE-360: Add interface for connecting to active connections from "Active Sessions" tab. 2019-08-11 14:30:31 -07:00
Michael Jumper
1645516156 GUACAMOLE-360: Add TunnelRequestService support for joining active connections. 2019-08-11 14:30:31 -07:00
Michael Jumper
1c7242b800 GUACAMOLE-360: Refactor TunnelRequestService to handle any Connectable supported by TunnelRequestType. 2019-08-11 14:30:31 -07:00
Michael Jumper
403431bf92 GUACAMOLE-360: Add support for joining active connections to the database auth. 2019-08-11 14:30:31 -07:00
Virtually Nick
8b172a98fc GUACAMOLE-234: Fix style, debug messages, and logger output. 2019-08-10 22:14:56 -04:00
Michael Jumper
a59e20eb8d GUACAMOLE-360: Allow connections to active connections at API level. 2019-08-10 17:19:29 -07:00
Virtually Nick
8c1a3f3435 GUACAMOLE-234: Remove stray catch block. 2019-08-10 13:57:51 -04:00
Virtually Nick
5ea518a390 GUACAMOLE-234: Update to latest available Apache Directory API. 2019-08-10 13:57:51 -04:00
Nick Couchman
ed568b1f55 GUACAMOLE-234: Tweaks to handling bind requests/failures. 2019-08-10 13:57:51 -04:00
Nick Couchman
742b0c4e65 GUACAMOLE-234: Correctly handle bind failure. 2019-08-10 13:57:51 -04:00
Nick Couchman
791cfeabbb GUACAMOLE-234: Only try LDAP bind if user authenticated with LDAP. 2019-08-10 13:57:51 -04:00
Nick Couchman
fc5c4c538e GUACAMOLE-234: Don't close the connection after bind. 2019-08-10 13:57:51 -04:00
Nick Couchman
d7d622051f GUACAMOLE-234: Change EqualityNode to PresenceNode for wildcard objectClass. 2019-08-10 13:57:51 -04:00
Nick Couchman
72dad76d42 GUACAMOLE-234: Adjust LDAP filters. 2019-08-10 13:57:51 -04:00
Nick Couchman
7825f57b99 GUACAMOLE-234: Correct counter for referral hops. 2019-08-10 13:57:51 -04:00
Nick Couchman
7a17b7f935 GUACAMOLE-234: Add storage for the LDAP Bind DN to LDAPAuthenticateduser. 2019-08-10 13:57:51 -04:00
Nick Couchman
d0b1d7639e GUACAMOLE-234: Clean up comments, instanceof, and type-casting. 2019-08-10 13:57:09 -04:00
Nick Couchman
4aa4489b78 GUACAMOLE-234: Correct LDAP filter mispelling. 2019-08-10 13:56:12 -04:00
Nick Couchman
288fcb5e13 GUACAMOLE-234: Exclude slf4j from Apache Directory dependency. 2019-08-10 13:56:11 -04:00
Nick Couchman
41e3b8ca56 GUACAMOLE-234: Clean up comments. 2019-08-10 13:56:11 -04:00
Nick Couchman
5777d93fdc GUACAMOLE-234: Clean up some LDAP implementation details. 2019-08-10 13:56:11 -04:00