Commit Graph

5180 Commits

Author SHA1 Message Date
Mike Jumper
e9ed4150b9 GUACAMOLE-302: Merge narrowing of guacFocus behavior to simply setting/removing focus.
Additionally reporting whether the affected element receives or loses focus causes trouble if the source of the original value is non-assignable. It also seems like it could cause unexpected side effects if usages of guacFocus expect to separate their intent (assigning a value via the expression watched by guacFocus) from the result of attempting to set/remove focus. If tracking of focus is needed, that would best be served by another directive dedicated solely to tracking.
2019-06-25 13:04:42 -07:00
m-khan-glyptodon
68e5779592 GUACAMOLE-302: Make the binding of the guacFocus directive unidirectional.
There is an unassignable expression in the form directive that was being assinged a value by the guacFocus directive. The part that deals with this assigning is removed since no part of the app is relying upon this feature.
2019-06-25 12:00:59 -07:00
Mike Jumper
1818b6a7ee GUACAMOLE-302: Merge logic for automatically focusing relevant login fields. 2019-06-24 14:54:38 -07:00
m-khan-glyptodon
cfefd11e90 GUACAMOLE-302: Additions made to every remaining field (every field except username and password) so that they can now be manually focussed using the custom guacFocus directive. 2019-06-24 14:48:44 -07:00
m-khan-glyptodon
eb50c5c0e8 GUACAMOLE-302: Additions made to the username and password field types so that they can now be manually focussed using the custom guacFocus directive. 2019-06-24 14:48:44 -07:00
m-khan-glyptodon
19f0de4ebc GUACAMOLE-302: Allow guacForm and guacFormField directives to specify which field needs to be focused. 2019-06-24 14:48:44 -07:00
m-khan-glyptodon
52d2fe1661 GUACAMOLE-302: Additions are made to the login directive so that the appropriate field that needs to be focussed is determined. 2019-06-24 14:48:44 -07:00
Michael Jumper
00f59420e5 Merge 1.1.0 changes back to master. 2019-06-23 19:37:32 -07:00
Virtually Nick
30f6ac434b GUACAMOLE-723: Merge display connection selection menu only if multiple connections are available. 2019-06-23 22:32:08 -04:00
Mike Jumper
f5aa986e63 GUACAMOLE-579: Merge support for retrieving user attributes CAS. 2019-06-23 19:20:14 -07:00
Michael Jumper
3d71f84f0a GUACAMOLE-723: Display connection selection menu only if multiple choices are available. 2019-06-23 12:48:36 -07:00
Michael Jumper
40ee0d3775 GUACAMOLE-723: Consider entire connection hierarchy when determining whether only one connection is available. 2019-06-23 12:39:44 -07:00
Virtually Nick
b1d3070748 GUACAMOLE-723: Merge automatically close menus upon click unless explicitly marked as interactive. 2019-06-23 08:19:39 -04:00
Virtually Nick
b0460912b8 GUACAMOLE-723: Merge allow connection names to cleanly overflow in connection selection menu. 2019-06-23 08:18:20 -04:00
Michael Jumper
47ed39fb33 GUACAMOLE-723: Prefer a wider connection selection menu, but no wider than the sidebar. 2019-06-22 18:54:17 -07:00
Michael Jumper
93dbf85a14 GUACAMOLE-723: Automatically close menus upon click unless explicitly marked as interactive. 2019-06-22 18:41:29 -07:00
Michael Jumper
0e33525d7b GUACAMOLE-723: Use ellipsis for overflowing connection names within the connection selection menu. 2019-06-22 17:47:57 -07:00
Virtually Nick
9c26a7613c GUACAMOLE-579: Remove unnecessary JUnit dependencies. 2019-06-22 20:02:46 -04:00
Virtually Nick
7f26ba7a52 GUACAMOLE-579: Insure that CAS is providing a username. 2019-06-22 19:27:52 -04:00
Virtually Nick
a2b3e235e0 GUACAMOLE-579: Fix up documentation issues. 2019-06-22 19:27:33 -04:00
Virtually Nick
8ec139098a GUACAMOLE-723: Merge allow connection name to display cleanly in menu. 2019-06-22 17:39:05 -04:00
Virtually Nick
a6601a2bfd GUACAMOLE-579: Change fromAttribute to canonicalize 2019-06-21 12:54:42 -04:00
Virtually Nick
d8db630dbd GUACAMOLE-579: Clean up comments, implement convenience method for tokens without a prefix, and remove unneeded classes. 2019-06-20 20:41:41 -04:00
Virtually Nick
8ab9e51009 GUACAMOLE-579: Put back original init method for compatibility. 2019-06-20 19:52:06 -04:00
Nick Couchman
55c4144fbf GUACAMOLE-579: Parse tokens from attributes provided by the CAS server. 2019-06-20 19:52:06 -04:00
Michael Jumper
5f1c70e737 Merge 1.1.0 changes back to master. 2019-06-17 18:38:29 -07:00
Mike Jumper
82ea1d6ff5 GUACAMOLE-354: Merge translation and definition for Swiss German keymap option. 2019-06-17 18:34:02 -07:00
Michael Jumper
e412742b59 GUACAMOLE-723: Apply ellipsis to all overflowing menu titles by default. 2019-06-15 18:49:32 -07:00
Michael Jumper
e351b355a5 GUACAMOLE-723: Apply ellipsis when connection name overflows available space, regardless of whether the connection selection menu is used. 2019-06-15 18:35:14 -07:00
Michael Jumper
a084ad41de GUACAMOLE-723: Padding adjustment should be made only to the connection select menu. 2019-06-15 18:11:23 -07:00
Michael Jumper
18e1ec2240 GUACAMOLE-723: Apply ellipsis to portion of connection name that overflows connection selection menu title. 2019-06-15 18:08:40 -07:00
Michael Jumper
4f41890e2b GUACAMOLE-723: Separate connection selection menu to own CSS class. 2019-06-15 18:05:03 -07:00
Virtually Nick
1b48f21573 merge 1.1.0 changes back to master. 2019-06-15 17:16:40 -04:00
Virtually Nick
ce106d6426 GUACAMOLE-815: Merge remove duplicated "timezone" field definitions and translations. 2019-06-15 17:15:13 -04:00
Virtually Nick
15bb363de3 Merge 1.1.0 changes back to master. 2019-06-15 17:11:13 -04:00
Virtually Nick
8b239aec76 GUACAMOLE-422: Merge use consistent mechanism for locale preferences. 2019-06-15 17:09:53 -04:00
Michael Jumper
48ce083ad7 GUACAMOLE-815: Remove duplicated "timezone" field definitions and translations. 2019-06-15 14:00:32 -07:00
Michael Jumper
78977ae4fc GUACAMOLE-422: Use the same display mechanism and structure (the guacForm directive) for all locale preferences, not just the time zone. 2019-06-15 13:43:28 -07:00
Michael Jumper
ec963dd036 GUACAMOLE-422: Define field type which represents the ID of any supported language. 2019-06-15 13:40:16 -07:00
Virtually Nick
6dad3b249c Merge 1.1.0 changes back to master. 2019-06-08 17:45:42 -04:00
Virtually Nick
28833f3792 GUACAMOLE-422: Merge allow arbitrary versions of the Guacamole protocol to be represented. 2019-06-08 17:44:42 -04:00
Virtually Nick
ee6a79933e Merge 1.1.0 changes bcak to master. 2019-06-08 17:34:11 -04:00
Virtually Nick
203c4d9b58 GUACAMOLE-422: Merge correct non-short-circuit logic in null check. 2019-06-08 17:32:41 -04:00
Michael Jumper
092657aa79 GUACAMOLE-422: Replace non-short-circuit logic in null check (&) with proper short-circuit logic (&&).
Checking `timezone != null & !timezone.isEmpty()` will result in a
`NullPointerException` when `timezone` is null, as the `&` ensures
`timezone.isEmpty()` will run in all cases.
2019-06-08 13:44:45 -07:00
Michael Jumper
1e676559a5 GUACAMOLE-422: Correct toString() for GuacamoleProtocolVersion (must be manually implemented after migrating away from enum). Add unit test for verifying toString(). 2019-06-08 13:37:28 -07:00
Michael Jumper
84bbbc4fa0 GUACAMOLE-422: Add unit test for verifying GuacamoleProtocolVersion. 2019-06-08 13:23:47 -07:00
Michael Jumper
df9a0b1662 GUACAMOLE-422: Implement equals() and hashCode() for GuacamoleProtocolVersion. 2019-06-08 12:55:17 -07:00
Michael Jumper
dc66f84d71 GUACAMOLE-422: Clarify behavior of atLeast(). 2019-06-08 12:51:08 -07:00
Michael Jumper
8aff7b6f5b GUACAMOLE-422: Correct logic error in atLeast() - this version should be compared against otherVersion. 2019-06-08 12:48:01 -07:00
Michael Jumper
9d1b264417 GUACAMOLE-422: Clarify meaning of protocol capabilities. 2019-06-08 12:44:00 -07:00